[
https://issues.apache.org/jira/browse/GEODE-5495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16568452#comment-16568452
]
ASF subversion and git services commented on GEODE-5495:
--------------------------------------------------------
Commit acb50f94157c25ada4163771758115a1cb108516 in geode's branch
refs/heads/develop from [~mcmellawatt]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=acb50f9 ]
GEODE-5495: Destroy available ID before decrement in updateHAContainer()
Co-authored-by: Ryan McMahon <[email protected]>
Co-authored-by: Lynn Hughes-Godfrey <[email protected]>
> Double decrement of HAEventWrapper ref count due to race between QRM and
> DestroyRQ
> ----------------------------------------------------------------------------------
>
> Key: GEODE-5495
> URL: https://issues.apache.org/jira/browse/GEODE-5495
> Project: Geode
> Issue Type: Bug
> Components: client queues
> Reporter: Ryan McMahon
> Assignee: Ryan McMahon
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.8.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> When a client disconnects due to network issues e.g. SocketTimeoutExceptions
> we will destroy the HARegionQueue for that client. As part of that process,
> we decrement the reference count on the HAEventWrappers used by that client
> in the HAContainer.
> However, we may still be receiving queue removal messages for that client
> which results in a decrement of those same HAEventWrappers. This double
> decrementing can result in premature removal of the HAEventWrapper from the
> HAContainer even though other clients still need it.
> We need to prevent this double decrementing and premature removal, perhaps
> through synchronization between the destroyRQ() logic and queue removal
> messages.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
