[ 
https://issues.apache.org/jira/browse/GEODE-5629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16594193#comment-16594193
 ] 

ASF subversion and git services commented on GEODE-5629:
--------------------------------------------------------

Commit e719331d03b3e3b1ae069b9db5b04cc928b96e3f in geode's branch 
refs/heads/concourse-staging from Dan Smith
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=e719331 ]

GEODE-5629: Changing GMSEncryptJUnitTest to use ConcurrencyRule

This test was not capturing exceptions from the background threads.
Using ConcurrenyRule to execute the background tests.


> GMSEncryptJUnitTest does not actually check the results of threads it starts
> ----------------------------------------------------------------------------
>
>                 Key: GEODE-5629
>                 URL: https://issues.apache.org/jira/browse/GEODE-5629
>             Project: Geode
>          Issue Type: Bug
>            Reporter: Dan Smith
>            Assignee: Dan Smith
>            Priority: Major
>              Labels: pull-request-available, swat
>          Time Spent: 1h
>  Remaining Estimate: 0h
>
> The testForClusterSecretKeyFromOtherMemberMultipleThreads method starts a 
> bunch of threads, but it does not actually check to see if they ran 
> successfully without an exception. It just waits for them to finish around 
> line 362. This test should be refactored to use the ConcurrencyRule.
> {code}
>  countDownLatch.await();
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to