[
https://issues.apache.org/jira/browse/GEODE-5662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16597836#comment-16597836
]
ASF subversion and git services commented on GEODE-5662:
--------------------------------------------------------
Commit 9e4912f762887ed574e5fdbc819e970671a06e57 in geode's branch
refs/heads/windows-heavy-lifter from [[email protected]]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=9e4912f ]
GEODE-5662: improve timeouts in ExecutorServiceRuleTest
All calls requiring a timeout now use Awaitility. Timeout for all
calls are defined centrally with a value of 2 minutes.
Remove tests that were actually testing Executors/ExecutorService.
> Flaky unit test ExecutorServiceRuleTest.threadCountTwoHasTwoThreads
> -------------------------------------------------------------------
>
> Key: GEODE-5662
> URL: https://issues.apache.org/jira/browse/GEODE-5662
> Project: Geode
> Issue Type: Bug
> Reporter: Dan Smith
> Assignee: Kirk Lund
> Priority: Major
> Labels: pull-request-available, swat
> Fix For: 1.8.0
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> This test failed in CI. To me it looks like this test seems to be assuming
> that if it schedules two tasks they will actually run concurrently, which may
> or may not happen depending on timing.
> https://concourse.apachegeode-ci.info/teams/main/pipelines/develop/jobs/Build/builds/403
> {noformat}
> org.apache.geode.test.junit.rules.ExecutorServiceRuleTest >
> threadCountTwoHasTwoThreads FAILED
> org.junit.ComparisonFailure: expected:<[2]> but was:<[1]>
> at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native
> Method)
> at
> sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
> at
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> at
> org.apache.geode.test.junit.rules.ExecutorServiceRuleTest.threadCountTwoHasTwoThreads(ExecutorServiceRuleTest.java:130)
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)