[ 
https://issues.apache.org/jira/browse/GEODE-5607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16605952#comment-16605952
 ] 

ASF subversion and git services commented on GEODE-5607:
--------------------------------------------------------

Commit b73f8bbde3e19942093e14f090789ee7bec5a299 in geode's branch 
refs/heads/develop from Juan José Ramos
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=b73f8bb ]

GEODE-5607: Replace Jmock with Mockito (#2414)

* GEODE-5607: Replace Jmock with Mockito

- Removed dependency to `org.jmock`.
- Migrated several test classes to use `Mockito` instead `Jmock`.
- Changed same classes to use `assertj` instead of `junit.Assert`.
- Changed same classes to use `Awaitility` instead of `WaitCriterion`.

* Minor fixes in test asserts

Several test methods had the wrong order in the `assertThat` calls.
Asserts were written as `assertThat(<exepcted>).is*(<actual>)`, now
they have been corrected to `assertThat(<actual>).is*(<expected>)`.

* Minor fixes in test classes


> Replace org.jmock with mockito
> ------------------------------
>
>                 Key: GEODE-5607
>                 URL: https://issues.apache.org/jira/browse/GEODE-5607
>             Project: Geode
>          Issue Type: Improvement
>          Components: tests
>            Reporter: Jens Deppe
>            Assignee: Juan José Ramos Cassella
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> We should consolidate on a single mocking framework. Older tests still use 
> jmock which should be replaced with mockito.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to