[ https://issues.apache.org/jira/browse/GEODE-5574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16607850#comment-16607850 ]
ASF subversion and git services commented on GEODE-5574: -------------------------------------------------------- Commit ba0517868539fa6448f0d5a425a0b66db8685f73 in geode's branch refs/heads/windows-heavy-lifter from [~dschneider] [ https://gitbox.apache.org/repos/asf?p=geode.git;h=ba05178 ] GEODE-5574: unit test coverage for RegionMapDestroy (#2431) GEODE-5574: improve unit test coverage of RegionMapDestroy This is a major rewrite of RegionMapDestroyTest. The test was changed enough that I doubt the diffs will be helpful. I changed it to use mocks except for the class under test. Each test method now has the pattern "given, do, verify". This unit test now covers 90% of the class (used to be 60%) and the uncovered code is debug logging and what I think is dead code. I made one small change to the product to use "putEntryIfAbsent" instead of "getEntryMap().putIfAbsent". > improve RegionMapDestroy unit test coverage > ------------------------------------------- > > Key: GEODE-5574 > URL: https://issues.apache.org/jira/browse/GEODE-5574 > Project: Geode > Issue Type: Test > Components: regions > Reporter: Darrel Schneider > Assignee: Darrel Schneider > Priority: Major > Labels: pull-request-available > Fix For: 1.8.0 > > Time Spent: 0.5h > Remaining Estimate: 0h > > The current RegionMapDestroyTest has 62% coverage of the RegionMapDestroy > class. > To aid future refactoring of TxApplyDestroy with RegionMapDestroy it would > help if the current RegionMapDestroy had better unit test coverage. -- This message was sent by Atlassian JIRA (v7.6.3#76005)