[ 
https://issues.apache.org/jira/browse/GEODE-5428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16622385#comment-16622385
 ] 

ASF subversion and git services commented on GEODE-5428:
--------------------------------------------------------

Commit 4da7c59049561588f87bd571213fed6ffede1de5 in geode's branch 
refs/heads/develop from mhansonp
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=4da7c59 ]

GEODE-5428: Refactored DurableClientTests due to massive duplication

The DurableClientSimpleDUnitTest class was huge and doing three different
types of testing, so the code was partitioned into classes representing
the types.

Further, there were some bugs that needed to be addressed in the code.

Co-Authored-By: Galen O'Sullivan <gosulli...@pivotal.io>

> SUPERFLAKY: DurableClientTestCase.testDurableHAFailover
> -------------------------------------------------------
>
>                 Key: GEODE-5428
>                 URL: https://issues.apache.org/jira/browse/GEODE-5428
>             Project: Geode
>          Issue Type: Task
>            Reporter: Dan Smith
>            Assignee: Mark Hanson
>            Priority: Major
>              Labels: pull-request-available, swat
>         Attachments: Test results - Class 
> org.apache.geode.internal.cache.tier.sockets.DurableClientTestCase.html
>
>          Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> This test failed frequently over many 200+ runs of DistributedTest. It looks 
> like this test was reenabled recently, See GEODE-3721.
> {noformat}
> 23 failures 
> org.apache.geode.internal.cache.tier.sockets.DurableClientCrashDUnitTest.testDurableHAFailover
>  (91.4179104477612% success rate)
> 19 failures 
> org.apache.geode.internal.cache.tier.sockets.DurableClientTestCase.testDurableHAFailover
>  (92.91044776119402% success rate)
> 2 failures 
> org.apache.geode.internal.cache.tier.sockets.DurableClientSimpleDUnitTest.testDurableHAFailover
>  (99.25373134328358% success rate)
> {noformat}
> {noformat}
> org.apache.geode.internal.cache.tier.sockets.DurableClientTestCase > 
> testDurableHAFailover FAILED
>       
>     org.apache.geode.test.dunit.RMIException: While invoking 
> org.apache.geode.internal.cache.tier.sockets.DurableClientTestCase$57.run in 
> VM 2 running on Host 70293b28b05f with 4 VMs
>       
>         at org.apache.geode.test.dunit.VM.invoke(VM.java:436)
>       
>         at org.apache.geode.test.dunit.VM.invoke(VM.java:405)
>       
>         at org.apache.geode.test.dunit.VM.invoke(VM.java:348)
>       
>         at 
> org.apache.geode.internal.cache.tier.sockets.DurableClientTestCase.checkPrimaryRecovery(DurableClientTestCase.java:1732)
>       
>         at 
> org.apache.geode.internal.cache.tier.sockets.DurableClientTestCase.durableFailover(DurableClientTestCase.java:1247)
>       
>         at 
> org.apache.geode.internal.cache.tier.sockets.DurableClientTestCase.testDurableHAFailover(DurableClientTestCase.java:1102)
>       
>       
>         Caused by:
>       
>         java.lang.AssertionError: Event never occurred after 30000 ms: Did 
> not detect primary recovery event during wait period
>       
>             at org.junit.Assert.fail(Assert.java:88)
>       
>             at 
> org.apache.geode.test.dunit.Wait.waitForCriterion(Wait.java:190)
>       
>             at 
> org.apache.geode.internal.cache.tier.sockets.DurableClientTestCase$57.run2(DurableClientTestCase.java:1746)
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to