[
https://issues.apache.org/jira/browse/GEODE-6019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16680586#comment-16680586
]
ASF subversion and git services commented on GEODE-6019:
--------------------------------------------------------
Commit 00c607fd506f6b470d1093c69ee375347ac69281 in geode's branch
refs/heads/develop from [~prhomberg]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=00c607f ]
GEODE-6019: Move gradle constants in constants files. (#2814)
* GEODE-6019: Move gradle constants in constants files.
* gradle.startParameter.continueOnFailure moved to settings.gradle
* Project properties group and scriptDir moved to gradle.properties
* Removed unnecessary import and semicolons in *.gradle
* Improved property and task comments
* Restore 'unnecessary' import that Gradle 4 includes in messy namespaces, but
Gradle 5 will require.
* tap-a tap-a tap-a.
> Gradle constants should be declared in gradle.properties when possible
> ----------------------------------------------------------------------
>
> Key: GEODE-6019
> URL: https://issues.apache.org/jira/browse/GEODE-6019
> Project: Geode
> Issue Type: Improvement
> Reporter: Patrick Rhomberg
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Build constants, such as the project {{group = org.apache.geode}}, should be
> declared in the {{gradle.properties}} whenever possible, rather than in the
> {{build.gradle}}.
> * As a constant, it needs not clutter our already-rather-involved build graph.
> * In many places, because project properties are read-only after
> initialization, we resort to {{ext}} to write property values, which are not
> robustly cached for performance (though this impact is likely trivial)
> * In some instances, such as third-party developers or particularly testing
> scenarios, we may wish to overwrite these constants on the command-line,
> which cannot be done when they are declared in {{build.gradle}}
> configurations.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
