[ 
https://issues.apache.org/jira/browse/GEODE-2644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16689884#comment-16689884
 ] 

ASF subversion and git services commented on GEODE-2644:
--------------------------------------------------------

Commit 743c925efa608719aca1ee6249d3c8ee3901905c in geode's branch 
refs/heads/feature/GEODE-6068 from [~apa...@the9muses.net]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=743c925 ]

Revert GEODE-2644 because offline diskstore commands generate info level logs

GFSH forks the offline diskstore commands in a JVM using log4j2-cli.xml
which sets the log level to WARN. However, the forked JVM creates a
Cache which then starts generating info level statements to STDOUT.

Revert "GEODE-2644: Remove log level from MonitorQueryUnderContentionBenchmark"
This reverts commit 6691d310e1263966991e584f712156d919dabecf.

Revert "GEODE-2644: Update session state caching dependencies for logging"
This reverts commit 688f58a4a75cc1297faa1dda201b971346c3a9fe.

Revert "GEODE-5637: Fix flaky SingleHopClientExecutorWithLoggingIntegrationTest"
This reverts commit 0a8f3dffa1ebaa618fafecc15bbc92ba8ba83696.

Revert "GEODE-2644: Make LogWriterAppender optional and support log4j2.xml"
This reverts commit 591f3f7840ce38c6100bff2040f396ad2469175e.

Revert "GEODE-2644: Expand DistributedSystemMXBean tests"
This reverts commit cd2bba13e2fb7e79f7634053a6c612050b328e11.

Revert "GEODE-2644: Make AlertAppender optional and support log4j2.xml"
This reverts commit 02c3cae1d38098259ff6aa4635c6e74f795bdc50.

Revert "GEODE-2644: Add LogConfig and StatisticsConfig for logging"
This reverts commit a77c94b349b3ed7fc873fc29f6852f9936843790.

Revert "GEODE-2644: Add AlertingTest JUnit Category"
This reverts commit 731cd2a7d35b086d34f8bbcb94a83c40739ae8ee.

Revert "GEODE-2644: Add LogFileAssert and LogLevelAssert assertions"
This reverts commit 5e61da5301469cdbd71ac186573f56c38e9a6cf0.

Revert "GEODE-2644: Cleanup logging related files"
This reverts commit 763e4177f201eff9b140654e6858152a1a184b8c.

Revert "GEODE-2644: Define interfaces for new Log4j2 Appenders"
This reverts commit efd8a14027195b6dae1dd3e4d53a33696ed318bb.


> Provide ability to configure Geode appenders in log4j2.xml
> ----------------------------------------------------------
>
>                 Key: GEODE-2644
>                 URL: https://issues.apache.org/jira/browse/GEODE-2644
>             Project: Geode
>          Issue Type: Improvement
>          Components: configuration, logging
>            Reporter: Kirk Lund
>            Assignee: Kirk Lund
>            Priority: Major
>              Labels: AlertAppender, Log4j2, LogWriterAppender, log4j2.xml, 
> pull-request-available
>             Fix For: 1.9.0
>
>          Time Spent: 7.5h
>  Remaining Estimate: 0h
>
> Presently Geode dynamically creates, adds and removes AlertAppender and 
> LogWriterAppender by manipulating log4j2 core API. We should move the bulk of 
> the Appender functionality to internal classes and just leave the Appenders 
> registered with log4j2 during the life of the JVM. 
> This allows us to enable and configure our Appenders via log4j2.xml and 
> control the Cache-controlled lifecycle internally without having to add and 
> remove custom Appender instances.
> The code would then become simpler, we could avoid invoking log4j2 core APIs, 
> and users would have control over configuring our use of log4j2 completely 
> within the .xml file. Presently, a user cannot configure our AlertAppender or 
> LogWriterAppender in log4j2.xml.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to