[
https://issues.apache.org/jira/browse/GEODE-2113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16742498#comment-16742498
]
ASF subversion and git services commented on GEODE-2113:
--------------------------------------------------------
Commit 4edbcbfdd291a1cb19b368af6d34a55e6d76c985 in geode's branch
refs/heads/feature/GEODE-2113e from Bruce Schuchardt
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=4edbcbf ]
GEODE-2113 Implement SSL over NIO
This commit fixes problems encountered in the previous implementation:
- position tracking for MsgReader has been moved into NioSslEngine and
NioPlainEngine because the Ssl engine sometimes needs to allocate a new
buffer and adjust the tracked read/process positions in the buffer
- the same buffer expansion methods in Buffers was being used for
read-side and write-side buffers but buffers being used for reads need
to be handled differently than buffers being used for writing
The first commit is the original implementation. The second commit
fixes the problems in that commit. If you've already reviewed the old
code you can probably just look at the second commit.
There is commented-out debugging code that I'll remove when these
changes pass the Pull Request Stress Tests.
> Implement SSL over NIO
> ----------------------
>
> Key: GEODE-2113
> URL: https://issues.apache.org/jira/browse/GEODE-2113
> Project: Geode
> Issue Type: Improvement
> Components: messaging
> Reporter: Addison
> Assignee: Bruce Schuchardt
> Priority: Major
> Labels: SmallFeature, pull-request-available
> Fix For: 1.9.0
>
> Time Spent: 5.5h
> Remaining Estimate: 0h
>
> Java now has a nifty javax.net.ssl.SSLSocketFactory that can produce an
> SSLSocket from an existing Socket. This will let us create an SSLSocket that
> has an NIO SocketChannel and get rid of all of the "Old IO" code.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
