[
https://issues.apache.org/jira/browse/GEODE-6279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16744280#comment-16744280
]
ASF subversion and git services commented on GEODE-6279:
--------------------------------------------------------
Commit d9945a13fff439e4e4c77b59472b2d3668b05424 in geode's branch
refs/heads/develop from Robert Houghton
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=d9945a1 ]
GEODE-6279 Correct pull-request-id encoding in URL (#3081)
* Extract common semver version parsing to shared_utilities.sh
* Fix use of pull-request resource to get PR number
* Cleanup pointlessly used buildid version file ; use modified input as obvious
output.
Co-authored-by: Patrick Rhomberg <prhomb...@pivotal.io>
Co-authored-by: Robert Houghton <rhough...@pivotal.io>
> CI: PR Test results URI is valid but unintentionally mangled. Many scripts
> reproduce effort.
> ---------------------------------------------------------------------------------------------
>
> Key: GEODE-6279
> URL: https://issues.apache.org/jira/browse/GEODE-6279
> Project: Geode
> Issue Type: Improvement
> Reporter: Patrick Rhomberg
> Assignee: Patrick Rhomberg
> Priority: Major
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> For instance, the test run
> [here|https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-pr/jobs/UpgradeTestOpenJDK8/builds/704]
> contains the following output in the {{archive_results}} step:
> {noformat}
> =-=-=-=-=-=-=-=-=-=-=-=-=-=-= Test Results URI
> =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
> http://files.apachegeode-ci.info/builds/apache-develop-pr/geode-pr-{"pr":"3032","commit":"a9a03f033e90b39aceab07b56919e6a4fef1e43d","committed":"2019-01-10T20:13:25Z"}/test-results/upgradeTest/1547153318/
> =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
> {noformat}
> This is a consequence of the diff-set for GEODE-6259 using the concourse
> version as the (Concourse) source of truth for versioning and expecting the
> version file to only contain the version string.
> Another underlying issue is that many of these scripts are (a) used in both
> the main pipeline as well as the PR pipeline and (b) nearly-but-imperfectly
> duplicate a great deal fo work between each script. These common tasks
> should be unified to a shared utilities that can be accessed by any of our
> scripts so that these pitfalls do not snare future developers.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
