[ 
https://issues.apache.org/jira/browse/GEODE-6866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16864282#comment-16864282
 ] 

ASF subversion and git services commented on GEODE-6866:
--------------------------------------------------------

Commit 799c0767ecb88366ee7842343e4cce2e6d616ab0 in geode's branch 
refs/heads/develop from Darrel Schneider
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=799c076 ]

GEODE-6730: optimize check for sender id differences (#3707)

GEODE-6866: log warning instead of throwing exception

This revision fixes both GEODE-6730 and GEODE-6866

Throwing an exception led to inconsistency because the operation made it into 
the region but not into the gateway sender or async event queue.
Once the warning is logged for a region it will not be logged again until a 
check is done that finds that the ids are consistent.
I had both the initial message (that the ids differ) and the subsequent message 
(that they are now consistent) both be logged as warnings so that if you see 
the first message you will also see the second.
If we logged the "everything is ok" at info level, then it is possible that 
they would only see the warning.

I thought it was best to at least have this log message instead of completely 
removing the check. It may help diagnose a case in the future when someone 
dynamically adds a gateway sender inconsistently.


> gateway sender/async event queue consistency check can cause write ops to be 
> applied to region but left out of queue
> --------------------------------------------------------------------------------------------------------------------
>
>                 Key: GEODE-6866
>                 URL: https://issues.apache.org/jira/browse/GEODE-6866
>             Project: Geode
>          Issue Type: Bug
>          Components: wan
>            Reporter: Darrel Schneider
>            Priority: Major
>
> After a write operation has modified a region a check is done to see if the 
> gateway sender ids and async event queue ids are consistent across the entire 
> cluster. If they are consistent then the event is added to the 
> gateway/asyncEvent queue. But if they are  not consistent an exception is 
> thrown. This will lead to items being in the region but never put in queue.
> So at this point, instead of throwing an exception, we should just log a 
> warning about the inconsistent configuration and go ahead and deliver the 
> event to the gateways/asyncEventQueues that we do have.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to