[
https://issues.apache.org/jira/browse/GEODE-6691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16865798#comment-16865798
]
ASF subversion and git services commented on GEODE-6691:
--------------------------------------------------------
Commit 9d9f1ad3a489c3f663de539ae7c8fe3ae3b987ac in geode's branch
refs/heads/develop from mivanac
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=9d9f1ad ]
GEODE-6691: SecurityService.authorize optimized (#3711)
Converting the key to a String instance is not deferred until we have get into
a real security service implementation.
> Callers of
> org.apache.geode.internal.security.SecurityService.authorize(Resource,
> Operation, String, String) could be optimized by passing the key Object
> instead of always converting it to a String
> -----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: GEODE-6691
> URL: https://issues.apache.org/jira/browse/GEODE-6691
> Project: Geode
> Issue Type: Improvement
> Components: client/server
> Reporter: Darrel Schneider
> Assignee: Mario Ivanac
> Priority: Major
> Labels: performance
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> Lots of client/server messages call
> org.apache.geode.internal.security.SecurityService.authorize(Resource,
> Operation, String, String).
> The last argument is called with "key.toString()". When the security service
> is the default legacy one (which does no security) then this conversion of
> the key Object to a String is not needed.
> This method could be changed to have its last parameter be an Object and then
> only in theIntegratedSecurityService do we need to call "toString()".
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
