[ 
https://issues.apache.org/jira/browse/GEODE-6807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16955169#comment-16955169
 ] 

ASF subversion and git services commented on GEODE-6807:
--------------------------------------------------------

Commit 0f8248ab93ce2e10dc84baa668e163af2b9a5974 in geode's branch 
refs/heads/develop from mivanac
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=0f8248a ]

GEODE-6807: cache adviseUpdate and adviseAllEventsOrCached


> changing advisors to cache advice can improve performance
> ---------------------------------------------------------
>
>                 Key: GEODE-6807
>                 URL: https://issues.apache.org/jira/browse/GEODE-6807
>             Project: Geode
>          Issue Type: Improvement
>          Components: core
>            Reporter: Darrel Schneider
>            Assignee: Mario Ivanac
>            Priority: Major
>              Labels: performance
>          Time Spent: 4.5h
>  Remaining Estimate: 0h
>
> Cluster messaging uses advisors to know what member of the cluster should be 
> sent a message.
> Currently, every time and advisor is asked for advice to iterates over its 
> profiles building up the advice in a HashSet that is returned.
> I found on a partitioned region client/server put benchmark (32 client 
> threads, 2 servers with redundancy 1) that if I changed the method 
> adviseAllEventsOrCached to remember what it computed, that it caused the put 
> throughput to increase by 8%. [Update I reran and did not see an improvement 
> so the original 8% difference may have been caused by something else].
> Advisors know when a profile is added, removed, or modified. When that 
> happens any advice it has cached can be dropped. Also, the requestors of 
> advice need to expect the Set they get back to be unmodifiable. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to