[ 
https://issues.apache.org/jira/browse/GEODE-7330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16958362#comment-16958362
 ] 

ASF subversion and git services commented on GEODE-7330:
--------------------------------------------------------

Commit f0c96db73263bb1b3cb04558f2a720d70f43421f in geode's branch 
refs/heads/feature/GEODE-7286 from Kirk Lund
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=f0c96db ]

GEODE-7330: Prevent RegionDestroyedException in FederatingManager (#4193)

* GEODE-7330: Prevent RegionDestroyedException in FederatingManager

Cleanup management classes:
* Reduce method and field visibility as much as possible
* Remove unnecessary uses of this
* Reorder fields and methods based on visibility and other modifiers
* Use @VisibleForTesting annotation
* Fixup formatting and variable names

Make all FederatingManager fields final:
* Remove field setters for tests
* Introduce FederatingManagerFactory
* Add FederatingManagerFactory system property for tests to
  SystemManagementService
* Inject all FederatingManager fields via constructor
* Use Geode APIs in MBeanFederationErrorPathDUnitTest

Rename MBeanFederationErrorHandlingDistributedTest:
* Rename MBeanFederationErrorPathDUnitTest as
  MBeanFederationErrorHandlingDistributedTest

> CI Failure: RebalanceCommandDUnitTest > testWithTimeOutAndRegion FAILED
> -----------------------------------------------------------------------
>
>                 Key: GEODE-7330
>                 URL: https://issues.apache.org/jira/browse/GEODE-7330
>             Project: Geode
>          Issue Type: Test
>          Components: jmx
>            Reporter: Ernest Burghardt
>            Assignee: Kirk Lund
>            Priority: Major
>             Fix For: 1.11.0
>
>          Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
>  
> {code:java}
> org.apache.geode.management.internal.cli.commands.RebalanceCommandDUnitTest > 
> testWithTimeOutAndRegion FAILED
>     java.lang.AssertionError: Suspicious strings were written to the log 
> during this run.
>     Fix the strings or use IgnoredException.addIgnoredException to ignore.
>     -----------------------------------------------------------------------
>     Found suspect string in log4j at line 2985
>     [fatal 2019/10/21 13:15:18.178 GMT <FederatingManager3> tid=716] Uncaught 
> exception in thread Thread[FederatingManager3,5,RMI Runtime]
>     org.apache.geode.cache.RegionDestroyedException: 
> org.apache.geode.internal.cache.DistributedRegion[path='/_monitoringRegion_172.17.0.18<v1>41001';scope=DISTRIBUTED_NO_ACK';dataPolicy=REPLICATE]
>       at 
> org.apache.geode.internal.cache.LocalRegion.checkRegionDestroyed(LocalRegion.java:7293)
>       at 
> org.apache.geode.internal.cache.LocalRegion.basicDestroyRegion(LocalRegion.java:6157)
>       at 
> org.apache.geode.internal.cache.DistributedRegion.basicDestroyRegion(DistributedRegion.java:1821)
>       at 
> org.apache.geode.internal.cache.LocalRegion.basicDestroyRegion(LocalRegion.java:6128)
>       at 
> org.apache.geode.internal.cache.LocalRegion.localDestroyRegion(LocalRegion.java:2251)
>       at 
> org.apache.geode.internal.cache.AbstractRegion.localDestroyRegion(AbstractRegion.java:453)
>       at 
> org.apache.geode.management.internal.FederatingManager.removeMemberArtifacts(FederatingManager.java:216)
>       at 
> org.apache.geode.management.internal.FederatingManager.access$000(FederatingManager.java:67)
>       at 
> org.apache.geode.management.internal.FederatingManager$RemoveMemberTask.run(FederatingManager.java:564)
>       at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
>       at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
>       at java.lang.Thread.run(Thread.java:748)
> {code}
>  
> https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/DistributedTestOpenJDK8/builds/1203
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to