[ 
https://issues.apache.org/jira/browse/GEODE-7551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16989843#comment-16989843
 ] 

ASF subversion and git services commented on GEODE-7551:
--------------------------------------------------------

Commit 5acfb7f2d37eca5544cad21f7f9c4aef6410b23a in geode's branch 
refs/heads/develop from Bruce Schuchardt
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=5acfb7f ]

GEODE-7551: Remove membership API dependency on ClusterDistributionManager 
(#4431)

* GEODE-7551: Remove membership API dependency on ClusterDistributionManager

ClusterDistributionManager was only being used to get canonical IDs and
to check for shutdown conditions.  I've modified the CDM to set shutdown
status in membership in its shutdown() method and have modified
membership to just use the current MembershipView (which contains any
surprise members) instead of asking CDM for a canonical ID, which just
grabs said MembershipView and does the same thing.

* removing ClusterDistributionManager from dependency exceptions in 
MembershipDependenciesJUnitTest as well

* reverting unnecessary API change

* Resurrecting the isCloseInProgress check

we have to keep views from being sent out when the DM initiates sending shutdown
messages.


> Remove membership API dependency on ClusterDistributionManager
> --------------------------------------------------------------
>
>                 Key: GEODE-7551
>                 URL: https://issues.apache.org/jira/browse/GEODE-7551
>             Project: Geode
>          Issue Type: Sub-task
>          Components: membership
>            Reporter: Bruce J Schuchardt
>            Assignee: Bruce J Schuchardt
>            Priority: Major
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> The membership API can't refer to ClusterDistributionManager if we're going 
> to create a membership module.  It's used very little in the API and 
> implementation classes.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to