[ 
https://issues.apache.org/jira/browse/GEODE-7532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16990077#comment-16990077
 ] 

Dan Smith commented on GEODE-7532:
----------------------------------

I created GEODE-7555 to move the PoolManager related functionality to a service 
that is attached to the ClientCache. I think that will make it easier for 
frameworks to wrap and/or mock the PoolManager, PoolFactory, etc.

I'm closing this issue in favor of GEODE-7555.

In the future, if we want to expose an API to allow users to install their own 
connection pools for use with Regions, Queries, etc. we can consider adding a 
way to register those pools. However, the interface required for a such a 
connection pool is very different from the existing Pool interface. It would 
need interfaces and methods related to retrieving connections, sending messages 
over those connections, etc. Therefore I don't think it makes sense to expose a 
register(Pool) method.

> PoolManagerImpl.register(:Pool) and PoolManagerImpl.unregister(:Pool) should 
> be declared on the PoolManager interface
> ---------------------------------------------------------------------------------------------------------------------
>
>                 Key: GEODE-7532
>                 URL: https://issues.apache.org/jira/browse/GEODE-7532
>             Project: Geode
>          Issue Type: Improvement
>          Components: client/server
>            Reporter: John Blum
>            Priority: Major
>
> For all general uses, and especially for framework and tooling purposes, both 
> {{register(:Pool)}} and {{unregister(:Pool)}} methods of the 
> {{PoolManagerImpl}} class should be part of the {{PoolManager}} interface 
> given both methods are technically part of the "{{public}}" API despite 
> {{PoolManagerImpl}} being "deemed" part of some "internal" API (which is 
> completely arbitrary and irrelevant since it is not properly enforced by the 
> language constructs of Java).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to