[ 
https://issues.apache.org/jira/browse/GEODE-7531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16999520#comment-16999520
 ] 

ASF subversion and git services commented on GEODE-7531:
--------------------------------------------------------

Commit efee065c00bf91bf6f2a7a86905af1c3451cb43d in geode's branch 
refs/heads/release/1.11.0 from Udo Kohlmeyer
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=efee065 ]

GEODE-7531: Added type checking before casting generic `Pool.java` to 
`PoolImpl.java` (#4490)


(cherry picked from commit f5b59350cc1b4580154df047f409a6c7a4095f0b)


> PoolManagerImpl.unregister(:Pool) naively assumes all Pool object instances 
> are PoolImpls
> -----------------------------------------------------------------------------------------
>
>                 Key: GEODE-7531
>                 URL: https://issues.apache.org/jira/browse/GEODE-7531
>             Project: Geode
>          Issue Type: Bug
>          Components: client/server
>    Affects Versions: 1.10.0
>         Environment: Apache Geode based applications on the JVM.
>            Reporter: John Blum
>            Assignee: Udo Kohlmeyer
>            Priority: Blocker
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> A recent 
> [change|https://github.com/apache/geode/blob/rel/v1.10.0/geode-core/src/main/java/org/apache/geode/internal/cache/PoolManagerImpl.java#L169-L174]
>  to the {{o.a.g.internal.cache.PoolManagerImpl}} class expects all 
> {{o.a.g.cache.client.Pools}} registered with the 
> {{o.a.g.cache.client.PoolManager}} to be 
> {{o.a.g.cache.client.internal.PoolImp}} objects.
> This is certainly not going to be the case for Unit Tests that properly 
> "mock" 1 or more {{Pool}} instances and additionally needs to register the 
> mock {{Pool}} instances with the {{PoolManager}}.  While the later may not be 
> as common for application code, it is more certainly common, and in some 
> cases necessary, for framework or tooling code.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to