[ 
https://issues.apache.org/jira/browse/GEODE-7301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17009541#comment-17009541
 ] 

Mario Kevo commented on GEODE-7301:
-----------------------------------

Hi [~bschuchardt] ,

I tried to move this part into the 'else' statement, but it failed. See PR 
[#4367.|https://github.com/apache/geode/pull/4367]

This change causes changes on the upgraded version, but as tests checks 
difference between old version(use ipAddress) and new version(with this change 
use hostName) and failed.

>From my point of view, we can now disable this flag and on the major release 
>remove it to always use hostnames.

> Remove code that disables the use of hostnames in membership identifiers
> ------------------------------------------------------------------------
>
>                 Key: GEODE-7301
>                 URL: https://issues.apache.org/jira/browse/GEODE-7301
>             Project: Geode
>          Issue Type: Improvement
>          Components: membership
>            Reporter: Bruce J Schuchardt
>            Assignee: Mario Kevo
>            Priority: Minor
>              Labels: low-hanging-fruit, newbie
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> When network-partition-detection is enabled membership identifiers use 
> numeric host IP addresses instead of host names.  This should be changed to 
> always use host names - much of the rest of Geode uses hostnames regardless 
> of how this setting is configured, so we're dependent on the computer's host 
> name resolution service anyway.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to