[ https://issues.apache.org/jira/browse/GEODE-6807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17048190#comment-17048190 ]
ASF subversion and git services commented on GEODE-6807: -------------------------------------------------------- Commit bf0012d6b01b6a4094fca1b2dc7a21f78603a26a in geode's branch refs/heads/develop from Mario Ivanac [ https://gitbox.apache.org/repos/asf?p=geode.git;h=bf0012d ] Feature/geode 6807 1 (#4711) * GEODE-6807: cache adviseUpdate and adviseAllEventsOrCached * GEODE-6807: update with comments * GEODE-6807: update adviseAllEventsOrCached method * GEODE-6807: update of solution with checking of version * GEODE-6807: remove assert from new code * GEODE-6807: Added UT and inRecovery update check * GEODE-6807: Added Concurrent Test * GEODE-6807: Added missing @Test and rebase * GEODE-6807: fix for race conditions > changing advisors to cache advice can improve performance > --------------------------------------------------------- > > Key: GEODE-6807 > URL: https://issues.apache.org/jira/browse/GEODE-6807 > Project: Geode > Issue Type: Improvement > Components: core > Reporter: Darrel Schneider > Assignee: Mario Ivanac > Priority: Major > Labels: needs-review, performance, pull-request-available > Time Spent: 7h > Remaining Estimate: 0h > > Cluster messaging uses advisors to know what member of the cluster should be > sent a message. > Currently, every time and advisor is asked for advice to iterates over its > profiles building up the advice in a HashSet that is returned. > I found on a partitioned region client/server put benchmark (32 client > threads, 2 servers with redundancy 1) that if I changed the method > adviseAllEventsOrCached to remember what it computed, that it caused the put > throughput to increase by 8%. [Update I reran and did not see an improvement > so the original 8% difference may have been caused by something else]. > Advisors know when a profile is added, removed, or modified. When that > happens any advice it has cached can be dropped. Also, the requestors of > advice need to expect the Set they get back to be unmodifiable. -- This message was sent by Atlassian Jira (v8.3.4#803005)