[
https://issues.apache.org/jira/browse/GEODE-7808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17055150#comment-17055150
]
ASF subversion and git services commented on GEODE-7808:
--------------------------------------------------------
Commit 5c2b959e98a6330ecaeddb4d26e11ea29f7a2d7f in geode's branch
refs/heads/mass-test-run from Bruce Schuchardt
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=5c2b959 ]
GEODE-7808: standardize on use of HostAndPort for creating connections (#4765)
* Squashed merge of feature/GEODE-7808
removed HostAddress
renamed LocatorAddress to HostAndPort
modified TcpClient methods to take a HostAndPort argument instead of
InetAddress
modified SocketCreator to take a HostAndPort argument instead of
InetAddress
* GEODE-7808 - standardize on use of HostAndPort for connection formation
This continues a previous PR that passed and was approved for merge.
This commit raises up several methods from SocketCreator into the
TcpSocketCreator interface. This is an intermediate commit. A
subsequent commit will refactor TcpSocketCreator to separate the client
and server methods for creating server-sockets and client connections to
server-sockets.
* refactored socket-creators to separate concerns
ServerSocketCreator holds methods for non-client comms
ClientSocketCreator holds methods that clients should use for comms
AdvancedSocketCreator holds methods for people who need to get around
the limitations of the other two interfaces
* adding missing interface
* move code out of inner-classes into first-class classes
* renaming interfaces and methods to be less confusing
* reinstate SocketCreator ip to hostname cache for performance
* changes from review comments
> standardize on use of LocatorAddress/HostAddress for connection formation
> -------------------------------------------------------------------------
>
> Key: GEODE-7808
> URL: https://issues.apache.org/jira/browse/GEODE-7808
> Project: Geode
> Issue Type: Improvement
> Components: membership, messaging
> Reporter: Bruce J Schuchardt
> Assignee: Bruce J Schuchardt
> Priority: Major
> Fix For: 1.13.0
>
> Time Spent: 7.5h
> Remaining Estimate: 0h
>
> We currently use InetAddress and InetSocketAddress in many places to identify
> locators, servers and peers. Some work has been done in the past couple of
> years to reduce the use of these in order to accommodate changes in IP
> addresses due to various causes. The class LocatorAddress was created to
> help with this and it is able to hold a host name without resolving it until
> that resolution is needed to form a tcp/ip connection.
> These days we are seeing more and more movement into cloud computing and the
> need to accommodate IP address changes is becoming a bigger issue. To that
> end we would like to change our primary client/server and WAN communication
> interfaces to stop taking InetAddresses and InetSocketAddresses as arguments
> and, instead, take something like a LocatorAddress that can hold an
> unresolved hostname that our communication implementations will resolve when
> needed.
> To that end we should also remove the hostname->inetaddress cache in
> SocketCreator and rely on the operating system's DNS cache.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
