[
https://issues.apache.org/jira/browse/GEODE-7890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17061362#comment-17061362
]
John Blum commented on GEODE-7890:
----------------------------------
By my account the following property constants (by name) in
{{ConfigurationProperties}} are not properly annotated with {{@Deprecated}},
however their _Javadoc_ includes the {{@deprecated}} meta Javadoc tag:
{code:java}
private static final Set<String> deprecatedGemFireProperties =
Collections.unmodifiableSet(new HashSet<>(Arrays.asList(
"cluster-ssl-ciphers", // all 'cluster-ssl-*' properties
replaced by 'ssl-*' properties
"cluster-ssl-enabled",
"cluster-ssl-keystore",
"cluster-ssl-keystore-password",
"cluster-ssl-keystore-type",
"cluster-ssl-protocols",
"cluster-ssl-require-authentication",
"cluster-ssl-truststore",
"cluster-ssl-truststore-password",
"jmx-manager-http-port", // replaced by 'http-service-port'
property
"roles",
"security-client-accessor", // replaced by SecurityManager
"security-client-accessor-pp", // replaced by SecurityManager
"security-client-authenticator", // replaced by SecurityManager
"security-client-dhalgo", // use SSL instead
"security-peer-authenticator" // replaced by SecurityManager
)));
{code}
> @Deprecated ConfigurationProperties should be applied consistently
> ------------------------------------------------------------------
>
> Key: GEODE-7890
> URL: https://issues.apache.org/jira/browse/GEODE-7890
> Project: Geode
> Issue Type: Bug
> Components: configuration
> Reporter: John Blum
> Priority: Minor
>
> The {{@Deprecated}} annotation was *not* appropriately and consistently
> applied to ALL
> [org.apache.geode.distributed.ConfigurationProperties|http://example.com]
> constants representing Apache Geode properties!
> For instance, all {{cluster-ssl-\*}} properties have been *deprecated* as
> indicated by the
> [CLUSTER_SSL_PREFIX|https://github.com/apache/geode/blob/rel/v1.11.0/geode-core/src/main/java/org/apache/geode/distributed/ConfigurationProperties.java#L169-L170]
> as well as the _Javadoc_ comments for individual {{CLUSTER_SSL_\*}} property
> constants, for
> [instance|https://github.com/apache/geode/blob/rel/v1.11.0/geode-core/src/main/java/org/apache/geode/distributed/ConfigurationProperties.java#L210].
> However, the actually
> [constant|https://github.com/apache/geode/blob/rel/v1.11.0/geode-core/src/main/java/org/apache/geode/distributed/ConfigurationProperties.java#L212]
> is *NOT* properly annotated with {{@Deprecated}}.
> This is unlike other property constants which have been properly *deprecated*
> using the {{@Deprecated}} annotation. For instance, the
> [Javadoc|https://github.com/apache/geode/blob/rel/v1.11.0/geode-core/src/main/java/org/apache/geode/distributed/ConfigurationProperties.java#L559-L560]
> and the {{@Deprecated}}
> [Annotation|https://github.com/apache/geode/blob/rel/v1.11.0/geode-core/src/main/java/org/apache/geode/distributed/ConfigurationProperties.java#L562-L563]
> applied to the constant.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
