[
https://issues.apache.org/jira/browse/GEODE-7871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17065889#comment-17065889
]
ASF subversion and git services commented on GEODE-7871:
--------------------------------------------------------
Commit d446cd620f2ebc32355594793b37d6ea437857a1 in geode's branch
refs/heads/feature/GEODE-6008b from Bruce Schuchardt
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=d446cd6 ]
GEODE-6008: CI Failure:
ClientServerHostNameVerificationDistributedTest.expectConnectionFailureWhenNoHostNameInServerKey
failed
The "Message distribution has terminated" failure is caused by an
unreported NullPointerException in a residual reader thread introduced
in the fix for GEODE-7727. That fix caused a thread to say alive in a
peer-to-peer tcp/ip Connection in order to clean up the receiving side
of a socket. The Connection shutdown method close() method, however,
releases the Connection's input buffer and nulls out the field. The
reader thread then threw an NPE that was caught and caused the
"Message distribution has terminated" message, which is picked up as a
suspect string by the testing infrastructure.
This problem is also seen in GEODE-7894, GEODE-7871, GEODE-7873 and
GEODE-7806.
The fix is to record the fact that a residual reader thread exists and
avoid releasing the Connection's input buffer when the connection is
closed. This lets the reader thread do the cleanup.
While testing the fix I found that the NioSslEngine was throwing an
IllegalStateException when the reader thread tried to use it in this
same situation. This exception wasn't being caught and caused more
suspect strings to be logged. I've changed this to a checked exception
that is already handled by the reader thread.
ClientServerHostNameVerificationDistributedTest also wasn't working on
my Mac due to its /etc/hosts configuration. I changed the test to allow
the IP address selected by LocalHostUtil to be a valid client/server
address for the SSL certificates it generates.
> CI Failure:
> ClientServerHostNameVerificationDistributedTest.expectConnectionFailureWhenNoHostNameInLocatorKey
> Failed
> --------------------------------------------------------------------------------------------------------------------
>
> Key: GEODE-7871
> URL: https://issues.apache.org/jira/browse/GEODE-7871
> Project: Geode
> Issue Type: Bug
> Components: membership
> Affects Versions: 1.12.0
> Reporter: Ivan Godwin
> Assignee: Bruce J Schuchardt
> Priority: Major
>
> ClientServerHostNameVerificationDistributedTest >
> expectConnectionFailureWhenNoHostNameInLocatorKey failed with the following
> output:
> {code:java}
> org.apache.geode.cache.client.internal.ClientServerHostNameVerificationDistributedTest
> > expectConnectionFailureWhenNoHostNameInLocatorKey FAILED
> java.lang.AssertionError: Suspicious strings were written to the log
> during this run.
> Fix the strings or use IgnoredException.addIgnoredException to ignore.
> -----------------------------------------------------------------------
> Found suspect string in log4j at line 3602
> [fatal 2020/03/12 02:42:26.780 GMT <unused p2p reader> tid=94] Uncaught
> exception in thread Thread[unused p2p reader,5,RMI Runtime]
> org.apache.geode.distributed.DistributedSystemDisconnectedException:
> Distribution manager on 172.17.0.14(server-2:95)<v2>:41002 started at Thu Mar
> 12 02:42:11 GMT 2020: Message distribution has terminated
> at
> org.apache.geode.distributed.internal.ClusterDistributionManager$Stopper.generateCancelledException(ClusterDistributionManager.java:2872)
> at
> org.apache.geode.internal.tcp.TCPConduit$Stopper.generateCancelledException(TCPConduit.java:1004)
> at
> org.apache.geode.CancelCriterion.checkCancelInProgress(CancelCriterion.java:83)
> at
> org.apache.geode.internal.tcp.Connection.readMessages(Connection.java:1666)
> at org.apache.geode.internal.tcp.Connection.run(Connection.java:1446)
> at java.base/java.lang.Thread.run(Thread.java:834)
> {code}
> https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/DistributedTestOpenJDK11/builds/1621
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
