[
https://issues.apache.org/jira/browse/GEODE-7565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17091563#comment-17091563
]
ASF GitHub Bot commented on GEODE-7565:
---------------------------------------
alb3rtobr commented on a change in pull request #4978:
URL: https://github.com/apache/geode/pull/4978#discussion_r414567295
##########
File path:
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/Ping.java
##########
@@ -55,12 +55,11 @@ public void cmdExecute(final Message clientMessage, final
ServerConnection serve
(InternalDistributedMember) clientMessage.getPart(0).getObject();
InternalDistributedMember myID = serverConnection.getCache().getMyId();
if (!myID.equals(targetServer)) {
- if (myID.compareTo(targetServer.getMemberIdentifier(), true, false)
== 0) {
+ if (myID.compareTo(targetServer, true, false) == 0) {
logger.warn("Target server {} has different viewId {}",
targetServer, myID);
writeErrorResponse(clientMessage, MessageType.EXCEPTION,
serverConnection);
} else {
pingCorrectServer(clientMessage, targetServer, serverConnection);
- writeReply(clientMessage, serverConnection);
Review comment:
@jujoramos Implementing tests I realized this writeReply here is
duplicated, `pingCorrectServer` is already calling it when the ping is
forwarded. So this should be the cause for the error you saw about an
unexpected REPLY message.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Wrong management of receivers with same hostname-for-senders
> ------------------------------------------------------------
>
> Key: GEODE-7565
> URL: https://issues.apache.org/jira/browse/GEODE-7565
> Project: Geode
> Issue Type: Improvement
> Components: wan
> Reporter: Alberto Bustamante Reyes
> Assignee: Alberto Bustamante Reyes
> Priority: Major
> Labels: pull
> Time Spent: 8h
> Remaining Estimate: 0h
>
> There is a problem with Geode WAN replication when GW receivers are
> configured with the same hostname-for-senders and port on all servers. [ 1 ]
> The problem experienced is that shutting down one server is stopping
> replication to this cluster until the server is up again. This is because
> Geode incorrectly assumes there are no more alive servers when just one of
> them is down, because since they share hostname-for-senders and port, they
> are treated as one same server.
> Our proposal consists on expanding internal data in locators with enough
> information to distinguish servers in the beforementioned use case. The same
> intervention is likely needed in the client pools and possibly elsewhere in
> the source code.
> ----
> [ 1 ] : The reason for such a setup is deploying Geode cluster on a
> Kubernetes cluster where all GW receivers are reachable from the outside
> world on the same VIP and port. Other kinds of configuration (different
> hostname and/or different port for each GW receiver) are not cheap from OAM
> and resources perspective in cloud native environments and also limit some
> important use-cases (like scaling).
>
> Link to thread in DEV mailing list:
> [https://markmail.org/thread/6qakx67rxiokdsec]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
