[
https://issues.apache.org/jira/browse/GEODE-7667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17096706#comment-17096706
]
ASF GitHub Bot commented on GEODE-7667:
---------------------------------------
DonalEvans commented on a change in pull request #4818:
URL: https://github.com/apache/geode/pull/4818#discussion_r418125679
##########
File path:
geode-core/src/distributedTest/java/org/apache/geode/internal/cache/ClearTXLockingDUnitTest.java
##########
@@ -49,13 +49,14 @@
* <p>
* GEODE-1740: It was observed that operations performed within a transaction
were not holding
* region modification locks for the duration of commit processing. This lock
is used to ensure
- * region consistency during CLEAR processing. By not holding the lock for the
duration of commit
+ * region consistency during CLEAR_REGION processing. By not holding the lock
for the duration of
+ * commit
* processing, a window was opened that allowed region operations such as
clear to occur in
* mid-commit.
*
* <p>
* The fix for GEODE-1740 was to acquire and hold read locks for any region
involved in the commit.
- * This forces CLEAR to wait until commit processing is complete.
+ * This forces CLEAR_REGION to wait until commit processing is complete.
Review comment:
Here.
##########
File path:
geode-core/src/distributedTest/java/org/apache/geode/internal/cache/ClearTXLockingDUnitTest.java
##########
@@ -49,13 +49,14 @@
* <p>
* GEODE-1740: It was observed that operations performed within a transaction
were not holding
* region modification locks for the duration of commit processing. This lock
is used to ensure
- * region consistency during CLEAR processing. By not holding the lock for the
duration of commit
+ * region consistency during CLEAR_REGION processing. By not holding the lock
for the duration of
Review comment:
Here. Also consider fixing the formatting on the comment, since spotless
has kind of messed it up following the accidental rename.
##########
File path:
geode-core/src/main/java/org/apache/geode/management/internal/i18n/CliStrings.java
##########
@@ -1914,9 +1921,10 @@
public static final String REMOVE__MSG__KEY_EMPTY = "Key is Null";
public static final String REMOVE__MSG__REGION_NOT_FOUND = "Region <{0}> Not
Found";
public static final String REMOVE__MSG__KEY_NOT_FOUND_REGION = "Key is not
present in the region";
- public static final String REMOVE__MSG__CLEARED_ALL_CLEARS = "Cleared all
keys in the region";
- public static final String
REMOVE__MSG__CLEARALL_NOT_SUPPORTED_FOR_PARTITIONREGION =
- "Option --" + REMOVE__ALL + " is not supported on partitioned region";
+ public static final String REMOVE__MSG__CLEARED_ALL_KEYS = "Cleared all keys
in the region";
Review comment:
I still think that renaming this to something like
"CLEAR_REGION_CLEARED_ALL_KEYS" and moving it to the "clear region" section of
constants would be worthwhile. It seems like a good idea to keep all
clear-related stuff in one place.
##########
File path:
geode-core/src/distributedTest/java/org/apache/geode/internal/cache/ClearTXLockingDUnitTest.java
##########
@@ -273,7 +274,7 @@ private void resetArmHook(String rname) {
}
/**
- * Wait to be notified it is time to perform region operation (i.e. CLEAR)
+ * Wait to be notified it is time to perform region operation (i.e.
CLEAR_REGION)
Review comment:
Here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> GFSH commands - uniform gfsh command to clear regions
> -----------------------------------------------------
>
> Key: GEODE-7667
> URL: https://issues.apache.org/jira/browse/GEODE-7667
> Project: Geode
> Issue Type: Sub-task
> Components: regions
> Reporter: Nabarun Nag
> Assignee: Benjamin P Ross
> Priority: Major
> Labels: GeodeCommons, docs
> Time Spent: 5h
> Remaining Estimate: 0h
>
> * Currently, the gfsh command to clear replicated region is called ‘remove
> —region=/regionName’.
> * Replace this command with ‘clear region —region=regionName’
> * While executing this gfsh command on partitioned regions, this should call
> the clear() Java API using the gfsh function execution machinery.
> * Point to note is that this command should take into consideration of the
> coordinator selection and how this command is distributed to the members
> Acceptance :
> * There should be ‘clear region —region=/regionName’ gfsh command
> * DUnit tests to verify that command can be executed successfully on
> PartitionedRegion
> * Deprecate the remove command, as remove does not mean clear
> * Unit tests with complete code coverage for the newly written code.
> * Test coverage to when a member departs in this scenario
> * Test coverage to when a member restarts in this scenario
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
