[
https://issues.apache.org/jira/browse/GEODE-8055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17099233#comment-17099233
]
ASF GitHub Bot commented on GEODE-8055:
---------------------------------------
gesterzhou commented on a change in pull request #5034:
URL: https://github.com/apache/geode/pull/5034#discussion_r419647457
##########
File path:
geode-core/src/main/java/org/apache/geode/cache/configuration/CacheConfig.java
##########
@@ -1024,11 +1025,22 @@ public void setVersion(String value) {
this.version = value;
}
+ // this supports looking for sub regions
public RegionConfig findRegionConfiguration(String regionPath) {
if (regionPath.startsWith(SEPARATOR)) {
regionPath = regionPath.substring(1);
}
- return find(getRegions(), regionPath);
+ List<RegionConfig> regions = getRegions();
+ RegionConfig found = null;
+ for (String regionToken : regionPath.split(SEPARATOR)) {
+ found = Identifiable.find(regions, regionToken);
Review comment:
I feel this logic need some comments or use better name for variables
found and regions.
It tried to find the last layer of subregion's RegionConfig and validate it
exists.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> can not create index on sub regions
> -----------------------------------
>
> Key: GEODE-8055
> URL: https://issues.apache.org/jira/browse/GEODE-8055
> Project: Geode
> Issue Type: Bug
> Components: gfsh
> Affects Versions: 1.7.0, 1.8.0, 1.10.0, 1.9.2, 1.11.0, 1.12.0
> Reporter: Jinmei Liao
> Priority: Major
>
> When trying to use "create index" command in gfsh to create index on sub
> regions, we get the following message:
> "Sub-regions are unsupported"
> Pre-1.6, we were able to do that.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
