[ https://issues.apache.org/jira/browse/GEODE-8073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17100264#comment-17100264 ]
ASF GitHub Bot commented on GEODE-8073: --------------------------------------- pivotal-eshu commented on a change in pull request #5055: URL: https://github.com/apache/geode/pull/5055#discussion_r420417517 ########## File path: geode-core/src/test/java/org/apache/geode/internal/cache/PartitionedRegionTest.java ########## @@ -573,6 +578,50 @@ public void transactionThrowsTransactionDataRebalancedExceptionIfIsAForceReattem .hasMessage(PartitionedRegion.DATA_MOVED_BY_REBALANCE).hasCause(exception); } + @Test + public void failuresSavedIfFetchKeysThrows() throws Exception { + PartitionedRegion spyPartitionedRegion = spy(partitionedRegion); + + VersionedObjectList values = mock(VersionedObjectList.class); + ServerConnection serverConnection = mock(ServerConnection.class); + Set<Integer> failures = mock(Set.class); Review comment: The mocked failures as a set is used later to verify whether a method is invoked on the set. Otherwise it would be hard to verify. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > NullPointerException thrown in PartitionedRegion.handleOldNodes > --------------------------------------------------------------- > > Key: GEODE-8073 > URL: https://issues.apache.org/jira/browse/GEODE-8073 > Project: Geode > Issue Type: Bug > Components: regions > Reporter: Eric Shu > Assignee: Eric Shu > Priority: Major > Labels: caching-applications > > The NPE can be thrown when a remote node is gone unexpectedly. > {noformat} > Caused by: java.lang.NullPointerException > at > org.apache.geode.internal.cache.PartitionedRegion.handleOldNodes(PartitionedRegion.java:4610) > at > org.apache.geode.internal.cache.PartitionedRegion.fetchEntries(PartitionedRegion.java:4689) > at > org.apache.geode.internal.cache.tier.sockets.BaseCommand.handleKVKeysPR(BaseCommand.java:1191) > at > org.apache.geode.internal.cache.tier.sockets.BaseCommand.handleKVAllKeys(BaseCommand.java:1124) > at > org.apache.geode.internal.cache.tier.sockets.BaseCommand.handleKeysValuesPolicy(BaseCommand.java:973) > at > org.apache.geode.internal.cache.tier.sockets.BaseCommand.fillAndSendRegisterInterestResponseChunks(BaseCommand.java:905) > at > org.apache.geode.internal.cache.tier.sockets.command.RegisterInterest61.cmdExecute(RegisterInterest61.java:260) > at > org.apache.geode.internal.cache.tier.sockets.BaseCommand.execute(BaseCommand.java:183) > at > org.apache.geode.internal.cache.tier.sockets.ServerConnection.doNormalMessage(ServerConnection.java:848) > at > org.apache.geode.internal.cache.tier.sockets.OriginalServerConnection.doOneMessage(OriginalServerConnection.java:72) > at > org.apache.geode.internal.cache.tier.sockets.ServerConnection.run(ServerConnection.java:1212) > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) > at > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) > at > org.apache.geode.internal.cache.tier.sockets.AcceptorImpl.lambda$initializeServerConnectionThreadPool$3(AcceptorImpl.java:686) > at > org.apache.geode.logging.internal.executors.LoggingThreadFactory.lambda$newThread$0(LoggingThreadFactory.java:119) > at java.lang.Thread.run(Thread.java:748) > {noformat} -- This message was sent by Atlassian Jira (v8.3.4#803005)