[
https://issues.apache.org/jira/browse/GEODE-7864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17101217#comment-17101217
]
ASF GitHub Bot commented on GEODE-7864:
---------------------------------------
DonalEvans commented on pull request #5049:
URL: https://github.com/apache/geode/pull/5049#issuecomment-624910507
> easy way to test is try changing Region.SEPARATOR to something else, right?
This is just a first-pass, fixing uses like `getRegion("/" + regionName)`.
It doesn't fix uses like `getRegion("/regionName")`. If you think it's better
to take an all or nothing approach rather than incremental improvements, I'm
okay with that too, but it might make proper review of the changes difficult.
The last thing I want to do is replace a filepath separator with
Region.SEPARATOR and have it slip through unnoticed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Code improvement refactoring
> ----------------------------
>
> Key: GEODE-7864
> URL: https://issues.apache.org/jira/browse/GEODE-7864
> Project: Geode
> Issue Type: Improvement
> Reporter: Nabarun Nag
> Priority: Major
> Time Spent: 13h 10m
> Remaining Estimate: 0h
>
> This is a placeholder ticket.
> * this is used to do refactoring.
> * this ticket number is used to number the commit message.
> * this ticket will never be closed.
> * it will be used to mark improvements like correcting spelling mistakes,
> efficient java code, etc.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
