[
https://issues.apache.org/jira/browse/GEODE-7971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17104418#comment-17104418
]
ASF GitHub Bot commented on GEODE-7971:
---------------------------------------
albertogpz commented on a change in pull request #4928:
URL: https://github.com/apache/geode/pull/4928#discussion_r423011534
##########
File path:
geode-wan/src/distributedTest/java/org/apache/geode/internal/cache/wan/WANTestBase.java
##########
@@ -519,7 +521,9 @@ public static void
createReplicatedRegionWithAsyncEventQueue(String regionName,
}
public static void createReplicatedRegionWithSenderAndAsyncEventQueue(String
regionName,
- String senderIds, String asyncChannelId, Boolean offHeap) {
+ String senderIds,
Review comment:
ok
##########
File path:
geode-wan/src/distributedTest/java/org/apache/geode/internal/cache/wan/WANTestBase.java
##########
@@ -560,7 +564,8 @@ public static void createReplicatedRegion(String
regionName, String senderIds, S
}
public static void createAsyncEventQueue(String asyncChannelId, boolean
isParallel,
- Integer maxMemory, Integer batchSize, boolean isConflation, boolean
isPersistent,
+ Integer maxMemory, Integer batchSize,
Review comment:
ok
##########
File path:
geode-wan/src/distributedTest/java/org/apache/geode/internal/cache/wan/WANTestBase.java
##########
@@ -589,7 +594,8 @@ public static void createAsyncEventQueue(String
asyncChannelId, boolean isParall
}
public static void createPartitionedRegion(String regionName, String
senderIds,
- Integer redundantCopies, Integer totalNumBuckets, Boolean offHeap) {
+ Integer redundantCopies, Integer totalNumBuckets,
Review comment:
ok
##########
File path:
geode-wan/src/distributedTest/java/org/apache/geode/internal/cache/wan/WANTestBase.java
##########
@@ -619,7 +625,8 @@ public static void createPartitionedRegion(String
regionName, String senderIds,
// TODO:OFFHEAP: add offheap flavor
public static void createPartitionedRegionWithPersistence(String regionName,
String senderIds,
- Integer redundantCopies, Integer totalNumBuckets) {
+ Integer redundantCopies,
Review comment:
ok
##########
File path:
geode-wan/src/distributedTest/java/org/apache/geode/internal/cache/wan/WANTestBase.java
##########
@@ -647,7 +654,9 @@ public static void
createPartitionedRegionWithPersistence(String regionName, Str
}
public static void createColocatedPartitionedRegion(String regionName,
String senderIds,
- Integer redundantCopies, Integer totalNumBuckets, String colocatedWith) {
+ Integer redundantCopies,
Review comment:
ok
##########
File path:
geode-wan/src/distributedTest/java/org/apache/geode/internal/cache/wan/WANTestBase.java
##########
@@ -691,7 +700,8 @@ public static void
addAsyncEventQueueThroughAttributesMutator(String regionName,
}
public static void createPartitionedRegionAsAccessor(String regionName,
String senderIds,
- Integer redundantCopies, Integer totalNumBuckets) {
+ Integer redundantCopies,
Review comment:
ok
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Gateway sender to deliver transaction events atomically to gateway receivers
> ----------------------------------------------------------------------------
>
> Key: GEODE-7971
> URL: https://issues.apache.org/jira/browse/GEODE-7971
> Project: Geode
> Issue Type: Improvement
> Components: wan
> Reporter: Alberto Gomez
> Assignee: Alberto Gomez
> Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
> The goal of this ticket is to implement the necessary changes in the gateway
> sender to prevent that events belonging to the same transaction are spread
> across different batches. In other words, to ensure that events from the same
> transaction are sent inside the same batch.
> This will be an optional feature on gateway senders to be enabled via a new
> parameter (--group-transaction-events) and will be restricted to serial
> gateway senders with just one dispatcher thread or to parallel gateway
> senders.
> Apart from the above restriction, grouping of events for a transaction inside
> the same batch may only be attained if the regions to which the events belong
> are replicated by the same set of gateway senders with the
> --group-transaction-events flag enabled. If this condition is not met, the
> events will be correctly delivered by the gateway senders but it will not be
> guaranteed that all events will always be sent inside the same batch.
> For more details see:
> [https://cwiki.apache.org/confluence/display/GEODE/Gw+sender+to+deliver+transaction+events+atomically+to+receivers]
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
