[
https://issues.apache.org/jira/browse/GEODE-8114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17106644#comment-17106644
]
ASF GitHub Bot commented on GEODE-8114:
---------------------------------------
prettyClouds commented on a change in pull request #5100:
URL: https://github.com/apache/geode/pull/5100#discussion_r424710264
##########
File path:
geode-redis/src/main/java/org/apache/geode/redis/internal/executor/set/RedisSetInRegion.java
##########
@@ -0,0 +1,109 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
contributor license
+ * agreements. See the NOTICE file distributed with this work for additional
information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express
+ * or implied. See the License for the specific language governing permissions
and limitations under
+ * the License.
+ */
+
+package org.apache.geode.redis.internal.executor.set;
+
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.List;
+import java.util.Set;
+import java.util.concurrent.atomic.AtomicBoolean;
+import java.util.regex.Pattern;
+
+import org.apache.geode.cache.Region;
+import org.apache.geode.redis.internal.ByteArrayWrapper;
+
+/**
+ * This class still uses "synchronized" to protect the underlying HashSet even
though all writers do
+ * so under the {@link SynchronizedStripedExecutor}. The synchronization on
this class can be
+ * removed once readers are changed to also use the {@link
SynchronizedStripedExecutor}.
+ */
+public class RedisSetInRegion implements RedisSetCommands {
+ private final Region<ByteArrayWrapper, RedisSet> region;
+
+ @SuppressWarnings("unchecked")
+ public RedisSetInRegion(Region<ByteArrayWrapper, RedisSet> region) {
+ this.region = region;
+ }
+
+ @Override
+ public long sadd(
+ ByteArrayWrapper key,
+ ArrayList<ByteArrayWrapper> membersToAdd) {
+
+ RedisSet redisSet = region.get(key);
+
+ if (redisSet != null) {
+ return redisSet.sadd(membersToAdd, region, key);
+ } else {
+ region.create(key, new RedisSet(membersToAdd));
+ return membersToAdd.size();
+ }
+ }
+
+ @Override
+ public long srem(
+ ByteArrayWrapper key,
+ ArrayList<ByteArrayWrapper> membersToRemove, AtomicBoolean
setWasDeleted) {
+ RedisSet redisSet = region.getOrDefault(key, RedisSet.EMPTY);
+ return redisSet.srem(membersToRemove, region, key, setWasDeleted);
+ }
+
+ public boolean del(ByteArrayWrapper key) {
+ return region.remove(key) != null;
+ }
+
+ @Override
+ public Set<ByteArrayWrapper> smembers(
+ ByteArrayWrapper key) {
+ RedisSet redisSet = region.getOrDefault(key, RedisSet.EMPTY);
Review comment:
sure, i can do that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Redis: refactor set classes to implement RedisSetCommands
> ---------------------------------------------------------
>
> Key: GEODE-8114
> URL: https://issues.apache.org/jira/browse/GEODE-8114
> Project: Geode
> Issue Type: Improvement
> Reporter: Murtuza Boxwala
> Priority: Major
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
