[
https://issues.apache.org/jira/browse/GEODE-8141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17109697#comment-17109697
]
ASF GitHub Bot commented on GEODE-8141:
---------------------------------------
DonalEvans opened a new pull request #5127:
URL: https://github.com/apache/geode/pull/5127
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced in
the commit message?
- [x] Has your PR been rebased against the latest commit within the target
branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [x] Does `gradlew build` run cleanly?
- [N/A] Have you written or updated unit tests to verify your changes?
- [N/A] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, check Concourse for build
issues and
submit an update to your PR as soon as possible. If you need help, please
send an
email to d...@geode.apache.org.
As the changes touch a huge number of files, the PR has been broken up into
chunks to allow easier reviewing.
To verify that all changes are correct and that no instances of "/" in
region names/paths have been missed, I replaced the character in
GeodePublicGlossary with a "~", updated oql.g to allow queries to be correctly
parsed using the new character, and ran all tests. All failing tests were
either directly comparing the region separator to "/", creating caches from XML
containing regions/indexes using "/" or involved older client/server versions
which would not be compatible with the changed separator.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Move definition of Region separator character to geode-common and make usage
> consistent throughout the codebase
> ---------------------------------------------------------------------------------------------------------------
>
> Key: GEODE-8141
> URL: https://issues.apache.org/jira/browse/GEODE-8141
> Project: Geode
> Issue Type: Task
> Reporter: Donal Evans
> Priority: Major
>
> The separator character for region paths is currently defined in the Region
> interface in geode-core. However, geode-management, which does not have a
> dependency on geode-core, uses the separator in several classes.
> * The definitions of the separator character and string should be moved to
> the geode-common module.
> * The currently existing definitions of the separator in the geode-core
> Region interface should be deprecated.
> * All instances of hardcoded '/' characters and strings should be replaced
> with references to the constants in geode-common.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
