[
https://issues.apache.org/jira/browse/GEODE-8166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17118889#comment-17118889
]
ASF GitHub Bot commented on GEODE-8166:
---------------------------------------
dschneider-pivotal commented on a change in pull request #5174:
URL: https://github.com/apache/geode/pull/5174#discussion_r431980369
##########
File path:
geode-redis/src/distributedTest/java/org/apache/geode/redis/executors/ExpireDUnitTest.java
##########
@@ -115,7 +113,7 @@ public static void tearDown() {
public void expireOnOneServer_shouldPropagateToAllServers() {
String key = "key";
- jedis1.set(key, "value");
+ jedis1.sadd(key, "value");
Review comment:
early on this branch, the new expiration was only working on sets and
hashes. So I changed these tests to use sets instead of strings. It seems like
this test is okay with any data type so I left it using a set.
##########
File path:
geode-redis/src/distributedTest/java/org/apache/geode/redis/executors/keys/PersistDUnitTest.java
##########
@@ -134,10 +133,8 @@ public void testConcurrentPersistOperations() throws
InterruptedException {
private void setKeysWithExpiration(Jedis jedis, Long iterationCount, String
key) {
for (int i = 0; i < iterationCount; i++) {
- SetParams setParams = new SetParams();
- setParams.ex(600);
-
- jedis.set(key + i, "value" + i, setParams);
+ jedis.sadd(key + i, "value" + 9);
+ jedis.expire(key + i, 600);
Review comment:
early on this branch, the new expiration was only working on sets and
hashes. So I changed these tests to use sets instead of strings. It seems like
this test is okay with any data type so I left it using a set.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Change redis expiration commands to use function+delta
> ------------------------------------------------------
>
> Key: GEODE-8166
> URL: https://issues.apache.org/jira/browse/GEODE-8166
> Project: Geode
> Issue Type: Improvement
> Components: redis
> Reporter: Darrel Schneider
> Assignee: Darrel Schneider
> Priority: Major
>
> The redis expiration commands (expire, pexpire, expireat, pexpireat, ttl,
> pttl, and persist) need to be reimplemented to use the new function+delta
> data model. They should also be careful to work correctly in a multi-node
> cluster if one of the servers die.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
