[ https://issues.apache.org/jira/browse/GEODE-8250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17145946#comment-17145946 ]
ASF GitHub Bot commented on GEODE-8250: --------------------------------------- kirklund commented on a change in pull request #5309: URL: https://github.com/apache/geode/pull/5309#discussion_r445904115 ########## File path: geode-assembly/src/acceptanceTest/java/org/apache/geode/management/internal/cli/commands/StartLocatorAcceptanceTest.java ########## @@ -14,43 +14,84 @@ */ package org.apache.geode.management.internal.cli.commands; +import static java.util.concurrent.TimeUnit.MILLISECONDS; +import static org.apache.geode.test.awaitility.GeodeAwaitility.getTimeout; import static org.assertj.core.api.Assertions.assertThat; +import java.nio.file.Path; + +import org.junit.After; +import org.junit.Before; import org.junit.Rule; import org.junit.Test; +import org.junit.rules.TemporaryFolder; +import org.apache.geode.internal.AvailablePortHelper; +import org.apache.geode.test.junit.rules.RequiresGeodeHome; import org.apache.geode.test.junit.rules.gfsh.GfshExecution; import org.apache.geode.test.junit.rules.gfsh.GfshRule; import org.apache.geode.test.junit.rules.gfsh.GfshScript; public class StartLocatorAcceptanceTest { + + private int locatorPort; + private int httpServicePort; + private Process locator; + private Path geodeDependencies; + private Path stdoutFile; + private Path locatorLogFile; + private Path pulseLogFile; + private Path javaBin; + @Rule public GfshRule gfshRule = new GfshRule(); + @Rule + public RequiresGeodeHome requiresGeodeHome = new RequiresGeodeHome(); Review comment: Wrong test ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Improve documentation for logging > --------------------------------- > > Key: GEODE-8250 > URL: https://issues.apache.org/jira/browse/GEODE-8250 > Project: Geode > Issue Type: Improvement > Components: docs > Reporter: Kirk Lund > Assignee: Kirk Lund > Priority: Major > Labels: GeodeOperationAPI, docs, logging > Fix For: 1.14.0 > > > The documentation pages for logging need some fixes, clarification, and > examples. Specifically the docs need updating to cover the newer geode-log4j > module and its custom appenders. Examples should include how to use custom > logging config with optional usage of the latest version of Geode's custom > appenders and pattern converters. -- This message was sent by Atlassian Jira (v8.3.4#803005)