[ https://issues.apache.org/jira/browse/GEODE-8337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17160162#comment-17160162 ]
ASF GitHub Bot commented on GEODE-8337: --------------------------------------- Bill commented on pull request #5355: URL: https://github.com/apache/geode/pull/5355#issuecomment-660300943 Thanks for the review @bschuchardt. I'm rewriting history on this PR now to get it down to the minimal number of commits (2). After CI runs on that I'll merge it! ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Rename Version enum to KnownVersion; VersionOrdinal to Version > -------------------------------------------------------------- > > Key: GEODE-8337 > URL: https://issues.apache.org/jira/browse/GEODE-8337 > Project: Geode > Issue Type: Improvement > Components: serialization > Reporter: Bill Burcham > Assignee: Bill Burcham > Priority: Major > Attachments: screenshot-1.png, screenshot-2.png > > > As a follow-on to GEODE-8240 and GEODE-8330, this is the final ticket, to > rename: > {{Version}} -> {{KnownVersion}} > {{VersionOrdinal}} -> {{Version}} > With this ticket, the work started in GEODE-8240 is complete. > After this change, the versioning hierarchy will be: > !screenshot-1.png! > Before this change, the hierarchy was: > !screenshot-2.png! > As part of this story we'll also harmonize version access methods on > MemberIdentifier, InternalDistributedMember, and GMSMemberData: > getVersionOrdinalObject() becomes getVersion() > On GMSMemberData: > setVersionObjectForTest() becomes setVersionForTest() -- This message was sent by Atlassian Jira (v8.3.4#803005)