[
https://issues.apache.org/jira/browse/GEODE-8386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17167039#comment-17167039
]
ASF GitHub Bot commented on GEODE-8386:
---------------------------------------
dschneider-pivotal opened a new pull request #5404:
URL: https://github.com/apache/geode/pull/5404
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in
the commit message?
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, check Concourse for build
issues and
submit an update to your PR as soon as possible. If you need help, please
send an
email to d...@geode.apache.org.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> SRANDMEMBER with negative count should return that many members
> ---------------------------------------------------------------
>
> Key: GEODE-8386
> URL: https://issues.apache.org/jira/browse/GEODE-8386
> Project: Geode
> Issue Type: Bug
> Components: redis
> Reporter: Darrel Schneider
> Assignee: Darrel Schneider
> Priority: Major
>
> When SRANDMEMBER is sent a negative count, it should return a number of items
> equal to the absolute value. uniqueness is not guaranteed.
>
> {{SADD abc 123 456
> SRANDMEMBER abc -1 -> 123
> SRANDMEMBER abc -2 -> 123, 123 OR 123, 456, 456, 123 OR 456, 456
> SRANDMEMBER abc -5 -> 123,123,456,123,456 OR any one of the 2^5
> combinations...}}
> see the redis unit tests and docs: unit/type/set -> SRANDMEMBER with <count>
> - hashtable
> and documentation: [https://redis.io/commands/srandmember]
> Currently, Geode Redis returns only up to as many members as there are in the
> set.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
