[ https://issues.apache.org/jira/browse/GEODE-8102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17175936#comment-17175936 ]
ASF GitHub Bot commented on GEODE-8102: --------------------------------------- codecov-commenter commented on pull request #630: URL: https://github.com/apache/geode-native/pull/630#issuecomment-672466067 # [Codecov](https://codecov.io/gh/apache/geode-native/pull/630?src=pr&el=h1) Report > Merging [#630](https://codecov.io/gh/apache/geode-native/pull/630?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/geode-native/commit/729185236e66377e5b367d40e43c8654314c60ed&el=desc) will **increase** coverage by `0.13%`. > The diff coverage is `93.80%`. [![Impacted file tree graph](https://codecov.io/gh/apache/geode-native/pull/630/graphs/tree.svg?width=650&height=150&src=pr&token=plpAqoqGag)](https://codecov.io/gh/apache/geode-native/pull/630?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## develop #630 +/- ## =========================================== + Coverage 73.91% 74.05% +0.13% =========================================== Files 642 641 -1 Lines 51084 50958 -126 =========================================== - Hits 37760 37737 -23 + Misses 13324 13221 -103 ``` | [Impacted Files](https://codecov.io/gh/apache/geode-native/pull/630?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [cppcache/src/Connector.hpp](https://codecov.io/gh/apache/geode-native/pull/630/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL0Nvbm5lY3Rvci5ocHA=) | `100.00% <ø> (ø)` | | | [cppcache/src/TcrConnection.hpp](https://codecov.io/gh/apache/geode-native/pull/630/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1RjckNvbm5lY3Rpb24uaHBw) | `100.00% <ø> (ø)` | | | [cppcache/src/TcpConn.cpp](https://codecov.io/gh/apache/geode-native/pull/630/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1RjcENvbm4uY3Bw) | `83.70% <88.88%> (+16.83%)` | :arrow_up: | | [cppcache/src/TcpSslConn.cpp](https://codecov.io/gh/apache/geode-native/pull/630/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1RjcFNzbENvbm4uY3Bw) | `94.73% <96.00%> (+25.17%)` | :arrow_up: | | [cppcache/src/TcpConn.hpp](https://codecov.io/gh/apache/geode-native/pull/630/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1RjcENvbm4uaHBw) | `100.00% <100.00%> (+53.84%)` | :arrow_up: | | [cppcache/src/TcpSslConn.hpp](https://codecov.io/gh/apache/geode-native/pull/630/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1RjcFNzbENvbm4uaHBw) | `100.00% <100.00%> (+50.00%)` | :arrow_up: | | [cppcache/src/TcrConnection.cpp](https://codecov.io/gh/apache/geode-native/pull/630/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1RjckNvbm5lY3Rpb24uY3Bw) | `72.58% <100.00%> (ø)` | | | [...test/testThinClientPoolExecuteHAFunctionPrSHOP.cpp](https://codecov.io/gh/apache/geode-native/pull/630/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvaW50ZWdyYXRpb24tdGVzdC90ZXN0VGhpbkNsaWVudFBvb2xFeGVjdXRlSEFGdW5jdGlvblByU0hPUC5jcHA=) | `91.20% <0.00%> (-3.71%)` | :arrow_down: | | [cppcache/include/geode/ExceptionTypes.hpp](https://codecov.io/gh/apache/geode-native/pull/630/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvaW5jbHVkZS9nZW9kZS9FeGNlcHRpb25UeXBlcy5ocHA=) | `38.40% <0.00%> (-0.73%)` | :arrow_down: | | [cppcache/src/TcrEndpoint.cpp](https://codecov.io/gh/apache/geode-native/pull/630/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1RjckVuZHBvaW50LmNwcA==) | `54.27% <0.00%> (-0.57%)` | :arrow_down: | | ... and [8 more](https://codecov.io/gh/apache/geode-native/pull/630/diff?src=pr&el=tree-more) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/geode-native/pull/630?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/geode-native/pull/630?src=pr&el=footer). Last update [7291852...d7edeb3](https://codecov.io/gh/apache/geode-native/pull/630?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Link and load OpenSSL library directly > -------------------------------------- > > Key: GEODE-8102 > URL: https://issues.apache.org/jira/browse/GEODE-8102 > Project: Geode > Issue Type: Improvement > Components: native client > Reporter: Jacob Barrett > Priority: Major > Labels: pull-request-available > > Lazy load the OpenSSL library directly, through ACE_SSL, into the > apache-geode library. Currently we lazy load cryptoImpl, which immediately > loads OpenSSL. The original intent was to avoid having an immediate > dependency on OpenSSL at a time when its availability was questionable. On > unix like systems OpenSSL is almost always available since so many other > components in the OS depend on it. This immediate load dependency will have > little to no effect on those systems. On some unix like systems the > experience will improve by not having a runtime dependency on an intermediate > library, cryptoImpl, that may need special treatments, like LD_LIBRARY_PATH > or RPATH changes. On Windows, where OpenSSL is an anomaly we can use MSVC's > lazy loading feature to only load OpenSSL if SSL/TLS is configured. This > significantly improves the experience on Windows with regards to the location > of cryptoImpl when using .NET. -- This message was sent by Atlassian Jira (v8.3.4#803005)