[
https://issues.apache.org/jira/browse/GEODE-8447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17184690#comment-17184690
]
ASF GitHub Bot commented on GEODE-8447:
---------------------------------------
jinmeiliao commented on a change in pull request #5469:
URL: https://github.com/apache/geode/pull/5469#discussion_r476679877
##########
File path:
geode-gfsh/src/test/java/org/apache/geode/management/internal/cli/json/QueryResultFormatterTest.java
##########
@@ -117,15 +119,19 @@ public void testPrimitives() throws Exception {
QueryResultFormatter stringResult = new
QueryResultFormatter(100).add(RESULT, "String");
checkResult(stringResult,
"{\"result\":[[\"java.lang.String\",\"String\"]]}");
+ Date date = new Date(0);
+ String expectedString =
+ new
SimpleDateFormat(QueryResultFormatter.DATE_FORMAT_PATTERN).format(date);
QueryResultFormatter javaDateResult =
- new QueryResultFormatter(100).add(RESULT, new java.util.Date(0));
+ new QueryResultFormatter(100).add(RESULT, date);
checkResult(javaDateResult,
-
"{\"result\":[[\"java.util.Date\",\"1970-01-01T00:00:00.000+0000\"]]}");
+ "{\"result\":[[\"java.util.Date\",\"" + expectedString + "\"]]}");
+ java.sql.Date sqlDatee = new java.sql.Date(0);
Review comment:
yeah, should be.e
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Pulse should localize “java.util.Date” in the displayed query result
> --------------------------------------------------------------------
>
> Key: GEODE-8447
> URL: https://issues.apache.org/jira/browse/GEODE-8447
> Project: Geode
> Issue Type: Bug
> Components: management
> Affects Versions: 1.12.0
> Reporter: Jinmei Liao
> Assignee: Jinmei Liao
> Priority: Major
> Labels: pull-request-available
> Attachments: CreatedOn-lastUpdated.JPG, Date-GF96.JPG
>
>
> In previous versions of Geode, Pulse used to show Dates in localized string,
> now it's not.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
