[
https://issues.apache.org/jira/browse/GEODE-8548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17205071#comment-17205071
]
ASF GitHub Bot commented on GEODE-8548:
---------------------------------------
gaussianrecurrence commented on pull request #659:
URL: https://github.com/apache/geode-native/pull/659#issuecomment-701680236
> Yikes, that's pretty subtle - I had to read it a couple of times to see
where the important change was. Looks good, and glad to see us get rid of this
call. Needless to say, it's super bad to have meaningful code executing inside
a LOG* macro.
>
> I'm verifying the build and tests on all platforms, then will merge if
everything checks out.
Yes, it was kind of a tricky one to troubleshoot haha. Thanks btw for
reviewing the PR :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> ACE_Inet_Addr takes too long in reverse DNS resolution
> ------------------------------------------------------
>
> Key: GEODE-8548
> URL: https://issues.apache.org/jira/browse/GEODE-8548
> Project: Geode
> Issue Type: Bug
> Components: native client
> Affects Versions: 1.11.0, 1.12.0, 1.13.0
> Reporter: Mario Salazar de Torres
> Assignee: Mario Salazar de Torres
> Priority: Major
> Labels: connections, pull-request-available
>
> Whenever TcpConn::connect is called, a system call to *get_host_name* is made
> in order to obtain reverse resolution for the connection address, right here:
> {code:cpp}
> void TcpConn::connect() {
> using apache::geode::internal::chrono::duration::to_string;
> ACE_OS::signal(SIGPIPE, SIG_IGN); // Ignore broken pipe
> LOGFINER(std::string("Connecting plain socket stream to ") +
> inetAddress_.get_host_name() + ":" +
> std::to_string(inetAddress_.get_port_number()) + " waiting " +
> to_string(timeout_));
> ยทยทยท
> {code}
> get_host_name executes getnameinfo underlying and the thing is that depending
> on your system configuration in the case of the address not having a reverse
> resolution entry it might take a long period. In my case it takes 10 seconds.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
