[ 
https://issues.apache.org/jira/browse/GEODE-8512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17209654#comment-17209654
 ] 

ASF GitHub Bot commented on GEODE-8512:
---------------------------------------

mmartell commented on pull request #661:
URL: https://github.com/apache/geode-native/pull/661#issuecomment-705045742


   Mario, this looks like a nice piece of new functionality. Your new test has 
uncovered a bug in our new C++ test framework 
(https://issues.apache.org/jira/browse/GEODE-8580). Fixing that first. Once 
that's merged I think we can merge your PR.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Be able to specify 'expectDomainClass' when calling createPdxInstanceFactory
> ----------------------------------------------------------------------------
>
>                 Key: GEODE-8512
>                 URL: https://issues.apache.org/jira/browse/GEODE-8512
>             Project: Geode
>          Issue Type: Improvement
>          Components: native client
>    Affects Versions: 1.13.0
>            Reporter: Mario Salazar de Torres
>            Assignee: Mario Salazar de Torres
>            Priority: Minor
>              Labels: JsonFormatter, pull-request-available
>
> Within Java client, you can specify if the PdxInstance you want to create is 
> a Java domain class or not, but this is not the case for geode-native C++ 
> client.
> Thing is that in order to implement JsonFormatter in C++ client, having this 
> change is mandatory, otherwise creating PdxType's with __GEMFIRE_JSON 
> classname will present some issues while using cquery's.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to