[
https://issues.apache.org/jira/browse/GEODE-8565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17209749#comment-17209749
]
ASF GitHub Bot commented on GEODE-8565:
---------------------------------------
pdxcodemonkey commented on pull request #662:
URL: https://github.com/apache/geode-native/pull/662#issuecomment-705105447
This has build issues on Windows:
```
C:\nativeclient\cppcache\integration\test\PartitionRegionOpsTest.cpp(106):
error C2079: 'previousTestLog' uses undefined class
'std::basic_ifstream<char,std::char_traits<char>>'
[C:\build\cppcache\integration\test\cpp-integration-test.vcxproj]
C:\nativeclient\cppcache\integration\test\PartitionRegionOpsTest.cpp(106):
error C2440: 'initializing': cannot convert from 'std::string' to 'int'
[C:\build\cppcache\integration\test\cpp-integration-test.vcxproj]
C:\nativeclient\cppcache\integration\test\PartitionRegionOpsTest.cpp(106):
note: No user-defined-conversion operator available that can perform this
conversion, or the operator cannot be called
C:\nativeclient\cppcache\integration\test\PartitionRegionOpsTest.cpp(115):
error C2079: 'testLog' uses undefined class
'std::basic_ifstream<char,std::char_traits<char>>'
[C:\build\cppcache\integration\test\cpp-integration-test.vcxproj]
C:\nativeclient\cppcache\integration\test\PartitionRegionOpsTest.cpp(115):
error C2440: 'initializing': cannot convert from 'std::string' to 'int'
[C:\build\cppcache\integration\test\cpp-integration-test.vcxproj]
C:\nativeclient\cppcache\integration\test\PartitionRegionOpsTest.cpp(115):
note: No user-defined-conversion operator available that can perform this
conversion, or the operator cannot be called
C:\nativeclient\cppcache\integration\test\PartitionRegionOpsTest.cpp(133):
error C2672: 'getline': no matching overloaded function found
[C:\build\cppcache\integration\test\cpp-integration-test.vcxproj]
C:\nativeclient\cppcache\integration\test\PartitionRegionOpsTest.cpp(133):
error C2784: 'std::basic_istream<_Elem,_Traits>
&std::getline(std::basic_istream<_Elem,_Traits>
&,std::basic_string<_Elem,_Traits,_Alloc> &)': could not deduce template
argument for 'std::basic_istream<_Elem,_Traits> &' from 'int'
[C:\build\cppcache\integration\test\cpp-integration-test.vcxproj]
C:\Program Files (x86)\Microsoft Visual
Studio\2017\Community\VC\Tools\MSVC\14.15.26726\include\string(160): note: see
declaration of 'std::getline'
C:\nativeclient\cppcache\integration\test\PartitionRegionOpsTest.cpp(133):
error C2780: 'std::basic_istream<_Elem,_Traits>
&std::getline(std::basic_istream<_Elem,_Traits>
&,std::basic_string<_Elem,_Traits,_Alloc> &,const _Elem)': expects 3 arguments
- 2 provided [C:\build\cppcache\integration\test\cpp-integration-test.vcxproj]
C:\Program Files (x86)\Microsoft Visual
Studio\2017\Community\VC\Tools\MSVC\14.15.26726\include\string(149): note: see
declaration of 'std::getline'
C:\nativeclient\cppcache\integration\test\PartitionRegionOpsTest.cpp(133):
error C2784: 'std::basic_istream<_Elem,_Traits>
&std::getline(std::basic_istream<_Elem,_Traits>
&&,std::basic_string<_Elem,_Traits,_Alloc> &)': could not deduce template
argument for 'std::basic_istream<_Elem,_Traits> &&' from 'int'
[C:\build\cppcache\integration\test\cpp-integration-test.vcxproj]
C:\Program Files (x86)\Microsoft Visual
Studio\2017\Community\VC\Tools\MSVC\14.15.26726\include\string(129): note: see
declaration of 'std::getline'
C:\nativeclient\cppcache\integration\test\PartitionRegionOpsTest.cpp(133):
error C2780: 'std::basic_istream<_Elem,_Traits>
&std::getline(std::basic_istream<_Elem,_Traits>
&&,std::basic_string<_Elem,_Traits,_Alloc> &,const _Elem)': expects 3 arguments
- 2 provided [C:\build\cppcache\integration\test\cpp-integration-test.vcxproj]
C:\Program Files (x86)\Microsoft Visual
Studio\2017\Community\VC\Tools\MSVC\14.15.26726\include\string(76): note: see
declaration of 'std::getline'
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> c++ client tries to connect to down server until IO error is thrown
> -------------------------------------------------------------------
>
> Key: GEODE-8565
> URL: https://issues.apache.org/jira/browse/GEODE-8565
> Project: Geode
> Issue Type: Improvement
> Components: native client
> Reporter: Alberto Bustamante Reyes
> Assignee: Alberto Bustamante Reyes
> Priority: Major
> Labels: pull-request-available
>
> This ticket is an improvement over GEODE-8231:
> {quote}If a C++ client connected to a cluster is sending operations to a
> partitioned region and one of the server goes down, the client keeps trying
> to send operations to the down server. This can be observed in the logs by a
> continuous flow of lines containing: "IO error in handshake with endpoint..."
> {quote}
> After that improvement, the c++ client removes the metadata info of the
> failing server once the "IO error in handshake" is received.
> But it has been observed that before that error is received, "timeout error"
> can be returned. So the client will try to reconnect until the "IO error in
> handshake" is received.
> This ticket aims to extend the GEODE-8231 solution so the client removes the
> server metadata information when a timeout is received.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
