[
https://issues.apache.org/jira/browse/GEODE-7845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17210974#comment-17210974
]
ASF GitHub Bot commented on GEODE-7845:
---------------------------------------
jujoramos commented on a change in pull request #5577:
URL: https://github.com/apache/geode/pull/5577#discussion_r502374738
##########
File path:
geode-core/src/main/java/org/apache/geode/cache/PartitionedRegionVersionException.java
##########
@@ -0,0 +1,29 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
contributor license
+ * agreements. See the NOTICE file distributed with this work for additional
information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express
+ * or implied. See the License for the specific language governing permissions
and limitations under
+ * the License.
+ */
+package org.apache.geode.cache;
+
+/**
+ * Indicates a failure to perform an operation on a Partitioned Region due to
+ * server versions not meeting requirements.
+ *
+ * @since GemFire 5.1
+ */
+public class PartitionedRegionVersionException extends CacheRuntimeException {
+ private static final long serialVersionUID = -3004093739855972548L;
+
+ public PartitionedRegionVersionException() {
+ super("A server's version was too old to a partition region clear");
+ }
Review comment:
The exception name seems a bit miss-leading to me, the "actual problem"
is the version of the members on which the partition region is hosted, not the
region itself. Maybe `UnsupportedVersionException`,
`IncompatibleVersionException` or something similar?.
It would also be good to include at least the id or name of one of the
members that's running an unsupported version within the exception message, it
will make the user's troubleshooting experience a lot better.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Rollingupgrade should not conflict with the new ClearPRMessage
> ---------------------------------------------------------------
>
> Key: GEODE-7845
> URL: https://issues.apache.org/jira/browse/GEODE-7845
> Project: Geode
> Issue Type: Improvement
> Components: core
> Reporter: Xiaojian Zhou
> Assignee: Mark Hanson
> Priority: Major
> Labels: GeodeCommons, pull-request-available
>
> PartitionedRegion clear introduced a new ClearPRMessage. In case of doing
> rolling upgrade, the user called PR.clear. The new ClearPRMessage should not
> fail. It should not be sent to the old members.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
