[
https://issues.apache.org/jira/browse/GEODE-8512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17212481#comment-17212481
]
ASF GitHub Bot commented on GEODE-8512:
---------------------------------------
pivotal-jbarrett commented on a change in pull request #661:
URL: https://github.com/apache/geode-native/pull/661#discussion_r503402216
##########
File path: cppcache/include/geode/Cache.hpp
##########
@@ -222,14 +222,25 @@ class APACHE_GEODE_EXPORT Cache : public GeodeCache {
/**
* Returns a factory that can create a {@link PdxInstance}.
* @param className the fully qualified class name that the PdxInstance will
- * become
- * when it is fully deserialized.
+ * become when it is fully deserialized.
* @throws IllegalStateException if the className is nullptr or invalid.
* @return the factory
*/
PdxInstanceFactory createPdxInstanceFactory(
const std::string& className) const override;
+ /**
+ * Returns a factory that can create a {@link PdxInstance}.
+ * @param className the fully qualified class name that the PdxInstance will
+ * become when it is fully deserialized.
+ * @param expectDomainClass Whether or not created PdxType represents a
+ * Java domain class.
+ * @throws IllegalStateException if the className is nullptr or invalid.
+ * @return the factory
+ */
+ PdxInstanceFactory createPdxInstanceFactory(
+ const std::string& className, bool expectDomainClass) const override;
Review comment:
Is the domain class thing actually specific to Java? I could also apply
to .NET or other languages where a reflection like behavior exists to
instantiate a type by name dynamically. If it is specific to Java then maybe
the param name should reflect that. If it isn't specific to Java then maybe the
documentation should change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Be able to specify 'expectDomainClass' when calling createPdxInstanceFactory
> ----------------------------------------------------------------------------
>
> Key: GEODE-8512
> URL: https://issues.apache.org/jira/browse/GEODE-8512
> Project: Geode
> Issue Type: Improvement
> Components: native client
> Affects Versions: 1.13.0
> Reporter: Mario Salazar de Torres
> Assignee: Mario Salazar de Torres
> Priority: Minor
> Labels: JsonFormatter, pull-request-available
>
> Within Java client, you can specify if the PdxInstance you want to create is
> a Java domain class or not, but this is not the case for geode-native C++
> client.
> Thing is that in order to implement JsonFormatter in C++ client, having this
> change is mandatory, otherwise creating PdxType's with __GEMFIRE_JSON
> classname will present some issues while using cquery's.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
