[
https://issues.apache.org/jira/browse/GEODE-8157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17219750#comment-17219750
]
ASF GitHub Bot commented on GEODE-8157:
---------------------------------------
pdxcodemonkey commented on a change in pull request #674:
URL: https://github.com/apache/geode-native/pull/674#discussion_r510963460
##########
File path: clicache/acceptance-test/SNITests.cs
##########
@@ -127,5 +133,38 @@ public void ConnectionWithoutProxyFails()
Assert.Throws<NotConnectedException>(() => region.Put("1", "one"));
}
+
Review comment:
This is probably a correct test until such time as we resolve
GEODE-8628. If it turns out NC should be honoring the read timeout value and
throwing a timeout exception (what I would've expected), then when we fix it to
do so properly, we can update this test to expect throw rather than just
checking if the put is complete. @echobravopapa I'm in favor of resolving this
bug and merging the new test, then writing one to actually shut down and
restart the proxy and catch the proper exception etc. To my mind, these are
different tests, both valid. Let us know what you think.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Write "drop proxy test" for C# (clicache)
> -----------------------------------------
>
> Key: GEODE-8157
> URL: https://issues.apache.org/jira/browse/GEODE-8157
> Project: Geode
> Issue Type: New Feature
> Components: native client
> Reporter: Blake Bender
> Priority: Major
> Labels: pull-request-available
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
