[
https://issues.apache.org/jira/browse/GEODE-8570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17223015#comment-17223015
]
ASF GitHub Bot commented on GEODE-8570:
---------------------------------------
kirklund commented on a change in pull request #5684:
URL: https://github.com/apache/geode/pull/5684#discussion_r514402987
##########
File path: geode-docs/reference/topics/gemfire_properties.html.md.erb
##########
@@ -117,7 +117,7 @@ Valid values are in the range 0...2147483647</td>
</tr>
<tr>
<td>cluster-configuration-dir</td>
-<td>This property specifies the directory in which the cluster configuration
related disk-store and artifacts are stored. This property is only applicable
to dedicated locators that have "enable-cluster-configuration" set to
true.</td>
+<td><b>Deprecated.</b> Use import/export clutser-configuration command
instead. This property specifies the directory in which the cluster
configuration related disk-store and artifacts are stored. This property is
only applicable to dedicated locators that have
"enable-cluster-configuration" set to true.</td>
Review comment:
I also recommend mentioning that it currently does nothing. We've done
this in the past for APIs that do nothing -- deprecate and document that it
does nothing and what the user should do instead.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> cluster-configuration-dir property has no effect
> ------------------------------------------------
>
> Key: GEODE-8570
> URL: https://issues.apache.org/jira/browse/GEODE-8570
> Project: Geode
> Issue Type: Bug
> Components: configuration
> Affects Versions: 1.13.0
> Reporter: Dale Emery
> Priority: Major
> Labels: GeodeOperationAPI, pull-request-available
>
> Setting the {{cluster-configuration-dir}} property has no effect.
> In two places, {{InternalLocator}} constructs an
> {{InternalConfigurationPersistenceService}}. In each place, it passes the
> locator's working directory as the persistence service's working directory,
> regardless of the value of {{cluster-configuration-dir}}.
> The use of this property should be deprecated, removed, or fixed.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
