[
https://issues.apache.org/jira/browse/GEODE-8684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17230720#comment-17230720
]
ASF GitHub Bot commented on GEODE-8684:
---------------------------------------
jdeppe-pivotal opened a new pull request #5737:
URL: https://github.com/apache/geode/pull/5737
This reverts commit ba8f9015530af10c3e9d1df1e73524bdc6c8a3cc.
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in
the commit message?
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, check Concourse for build
issues and
submit an update to your PR as soon as possible. If you need help, please
send an
email to d...@geode.apache.org.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Setting a session's maxInactiveInterval does not work when the commit valve
> is disabled
> ---------------------------------------------------------------------------------------
>
> Key: GEODE-8684
> URL: https://issues.apache.org/jira/browse/GEODE-8684
> Project: Geode
> Issue Type: Bug
> Components: http session
> Affects Versions: 1.14.0
> Reporter: Jens Deppe
> Assignee: Jens Deppe
> Priority: Major
> Labels: pull-request-available
>
> I was using the {{CommandServlet}}, in an external test, and noticed that
> when the commit valve is disabled, attempting to set the session's
> maxInactiveInterval does not cause the session's maxInactiveInterval to be
> changed and it remains at the default.
> My setup consisted of 2 Geode servers and a single Tomcat instance (9.0.39).
> I was checking the sessions with the following gfsh query:
> {code:java}
> query --query="select e.key,e.value.maxInactiveInterval from
> /gemfire_modules_sessions.entries as e
> {code}
> My {{context.xml}} includes the following:
> {code:xml}
> <Manager
> className="org.apache.geode.modules.session.catalina.Tomcat8DeltaSessionManager"
> enableLocalCache="false"
> enableCommitValve="false"
> regionAttributesId="PARTITION_REDUNDANT"
> />
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
