[ 
https://issues.apache.org/jira/browse/GEODE-8742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17242544#comment-17242544
 ] 

ASF GitHub Bot commented on GEODE-8742:
---------------------------------------

DonalEvans commented on a change in pull request #5803:
URL: https://github.com/apache/geode/pull/5803#discussion_r534344699



##########
File path: 
geode-wan/src/distributedTest/java/org/apache/geode/internal/cache/wan/wancommand/ListGatewaysCommandDUnitTest.java
##########
@@ -450,6 +450,30 @@ public void 
testListGatewaysReceiversOnlyFalseAndSendersOnlyFalseReturnsSendersA
         
.hasRowSize(expectedGwReceiverSectionSize).hasColumns().contains("Port", 
"Member");
   }
 
+  @Test
+  public void testListGatewaysWithOneDispatcherThread() {
+    String command =
+        "create gateway-sender --id=ln_Serial --remote-distributed-system-id=2 
--dispatcher-threads=1";

Review comment:
       Instead of hard-coding the gfsh command, would it be possible to use 
`CommandStringBuilder` with the static strings found in `CliStrings` here?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> List gateways command doesn't work properly
> -------------------------------------------
>
>                 Key: GEODE-8742
>                 URL: https://issues.apache.org/jira/browse/GEODE-8742
>             Project: Geode
>          Issue Type: Bug
>          Components: gfsh, wan
>    Affects Versions: 1.13.0, 1.13.1
>            Reporter: Mario Kevo
>            Assignee: Mario Kevo
>            Priority: Major
>              Labels: pull-request-available
>
> When you create serial gateway sender with dispatcher-threads equals to 1, 
> list gateways command will fail.
>  
> {code:java}
> Cluster-2 gfsh>list gateways
> Error while processing command <list gateways> Reason : null
> Cluster-2 gfsh>list gateways --senders-only
> Error while processing command <list gateways --senders-only> Reason : null
> Cluster-2 gfsh>list gateways --receivers-only
> GatewayReceiver Section
> Member | Port | Sender Count | Senders Connected
> ------------------------------------------ | ---- | ------------ | 
> -----------------
> 192.168.0.145(server-ln-1:27600)<v1>:41001 | 5094 | 0 | 
> 192.168.0.145(server-ln-2:27688)<v2>:41002 | 5434 | 0 |
>  
> {code}
>  
> It fails from introducing GEODE-7757, because it now looks on connected state 
> also to have more info in list gateways command.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to