[
https://issues.apache.org/jira/browse/GEODE-8747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17242653#comment-17242653
]
ASF GitHub Bot commented on GEODE-8747:
---------------------------------------
yozaner1324 opened a new pull request #5807:
URL: https://github.com/apache/geode/pull/5807
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in
the commit message?
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, check Concourse for build
issues and
submit an update to your PR as soon as possible. If you need help, please
send an
email to d...@geode.apache.org.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Collect library dependencies into single dependency
> ---------------------------------------------------
>
> Key: GEODE-8747
> URL: https://issues.apache.org/jira/browse/GEODE-8747
> Project: Geode
> Issue Type: New Feature
> Components: build
> Reporter: Udo Kohlmeyer
> Assignee: Patrick Johnson
> Priority: Major
>
> Library dependencies like Spring, Jackson, Spring Security, etc. usually have
> many dependencies. Which if used within a module, require the listing each of
> these dependencies.
> With the addition of ClassLoader Isolation a need arose, where these
> libraries where loaded into a single ClassLoader, instead of being loaded by
> the ClassLoaders of each of the modules that depended on these libraries.
> This feature is to replace the following:
> {code:groovy}
> implementation('org.springframework:spring-core')
> implementation('org.springframework:spring-beans')
> implementation('org.springframework:spring-context')
> implementation('org.springframework:spring-jcl')
> implementation('org.springframework:spring-web')
> implementation('org.springframework.shell:spring-shell')
> {code}
> with a single entry:
> {code:groovy}
> implementation(project(':frameworks:springframework'))
> {code}
> What this new construct allows for is a pattern closer to "using a framework"
> without having to explicitly define all the library dependencies. In this
> approach, we "use" a framework library, rather than knowing all of the
> internal dependencies.
> With this change, the ClassLoader isolation work, will only load each
> dependency once.
> Currently identified dependencies that require to be loaded only once are:
> Spring and Jackson
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
