[
https://issues.apache.org/jira/browse/GEODE-8820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17260905#comment-17260905
]
ASF GitHub Bot commented on GEODE-8820:
---------------------------------------
pivotal-jbarrett commented on a change in pull request #717:
URL: https://github.com/apache/geode-native/pull/717#discussion_r553679152
##########
File path: dependencies/ACE/CMakeLists.txt
##########
@@ -82,6 +82,7 @@ if (${WIN32})
set ( _CONFIGURE_COMMAND ${_COMMAND_PREFIX}
${CMAKE_COMMAND} -E env ACE_ROOT=<SOURCE_DIR>
SSL_ROOT=${OPENSSL_ROOT}
${MPC} ${MPC_FLAGS}
-name_modifier "*_${_TYPE}_static" -static
+ -value_template
WindowsTargetPlatformVersion=${CMAKE_SYSTEM_VERSION}
Review comment:
Does not match formatting of the surrounding lines.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Fix ACE 6.5.12 build break on Windows
> -------------------------------------
>
> Key: GEODE-8820
> URL: https://issues.apache.org/jira/browse/GEODE-8820
> Project: Geode
> Issue Type: Bug
> Components: native client
> Reporter: Michael Martell
> Priority: Major
> Labels: pull-request-available
>
> The recent upgrade to ACE version 6.5.12 has broken our CI build on Windows.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
