[ 
https://issues.apache.org/jira/browse/GEODE-8815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17261726#comment-17261726
 ] 

ASF subversion and git services commented on GEODE-8815:
--------------------------------------------------------

Commit 84f43e1ed75e670de4fe8663e4da7dfa952ffa87 in geode's branch 
refs/heads/develop from Jianxia Chen
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=84f43e1 ]

GEODE-8815: Cache could close with uncaught exception (#5882)

* Catch and log all possible throwables before closing the cache

* Add a unit test

> Cache could close with uncaught exception
> -----------------------------------------
>
>                 Key: GEODE-8815
>                 URL: https://issues.apache.org/jira/browse/GEODE-8815
>             Project: Geode
>          Issue Type: Bug
>            Reporter: Jianxia Chen
>            Assignee: Jianxia Chen
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.14.0
>
>
> In GemFireCacheImpl.initialize(), it is possible that an uncaught exception 
> is not logged and close the cache.
> {code:java}
>      try {
>       if (!isClient) {
>         applyJarAndXmlFromClusterConfig();
>       }
>       initializeDeclarativeCache();
>       completedCacheXml = true;
>     } catch (RuntimeException e) {
>       logger.error("Cache initialization for " + this.toString() + " failed 
> because:", e);
>       throw e;
>     } finally {
>       if (!completedCacheXml) {
>         // so initializeDeclarativeCache threw an exception
>         try {
>           close();
>         } catch (Throwable ignore) {
>           // I don't want init to throw an exception that came from the close.
>           // I want it to throw the original exception that came from 
> initializeDeclarativeCache.
>         }
>         configurationResponse = null;
>       }
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to