[ 
https://issues.apache.org/jira/browse/GEODE-8590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17265670#comment-17265670
 ] 

ASF GitHub Bot commented on GEODE-8590:
---------------------------------------

sabbey37 opened a new pull request #5906:
URL: https://github.com/apache/geode/pull/5906


   - Fixes Geode session state dependencies.
   - Fixes module manifest project detection.
   
   Thank you for submitting a contribution to Apache Geode.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?
   
   - [ ] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?
   
   - [ ] Is your initial contribution a single, squashed commit?
   
   - [ ] Does `gradlew build` run cleanly?
   
   - [ ] Have you written or updated unit tests to verify your changes?
   
   - [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
   
   ### Note:
   Please ensure that once the PR is submitted, check Concourse for build 
issues and
   submit an update to your PR as soon as possible. If you need help, please 
send an
   email to d...@geode.apache.org.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Session state modules leak dependencies in POM
> ----------------------------------------------
>
>                 Key: GEODE-8590
>                 URL: https://issues.apache.org/jira/browse/GEODE-8590
>             Project: Geode
>          Issue Type: Bug
>          Components: http session
>            Reporter: Jacob Barrett
>            Assignee: Jacob Barrett
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.14.0
>
>
> The http session state modules leak dependencies through the POM. Many of the 
> dependencies listed aren't even required. Many of those listed should be 
> compileOnly/provided scope since the modules are designed to be dropped into 
> a container which provides many of those dependencies.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to