[
https://issues.apache.org/jira/browse/GEODE-8735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17268882#comment-17268882
]
ASF GitHub Bot commented on GEODE-8735:
---------------------------------------
pivotal-jbarrett commented on a change in pull request #700:
URL: https://github.com/apache/geode-native/pull/700#discussion_r561322182
##########
File path: cppcache/integration/test/resources/pr_app_client_cache.xml
##########
@@ -0,0 +1,29 @@
+<?xml version="1.0"?>
+
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one or more
+ contributor license agreements. See the NOTICE file distributed with
+ this work for additional information regarding copyright ownership.
+ The ASF licenses this file to You under the Apache License, Version 2.0
+ (the "License"); you may not use this file except in compliance with
+ the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+-->
+<client-cache xmlns="http://geode.apache.org/schema/cache";
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
+
xsi:schemaLocation="http://geode.apache.org/schema/cache
http://geode.apache.org/schema/cache/cache-1.0.xsd";
Review comment:
Yes, but I think the parser is still non-validating so it won't really
matter. I suspect many of our client xml files are bad. The Java server and
client will validated and fail of the namespace and location are bad.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Enable factory lookup logic to look for symbols in the application
> ------------------------------------------------------------------
>
> Key: GEODE-8735
> URL: https://issues.apache.org/jira/browse/GEODE-8735
> Project: Geode
> Issue Type: Improvement
> Components: native client
> Affects Versions: 1.13.1
> Reporter: Mario Salazar de Torres
> Priority: Major
> Labels: pull-request-available
>
> *AS A* native client contributor
> *I WANT* to be able to specify factory names within the application space
> *SO THAT* the user does not need to create a separate shared library to load
> several items like partition resolvers, cache loaders, cache writers,
> partition resolvers...
> ----
> *Additional information*
> The rationale for this change is that if the user wants to declaratively
> specify a partition resolver, right now the only way is by creating the
> shared library.
> So the idea would be to change the current factory implementation, so library
> name is an optional field, and whenever "library-name" is not specified, the
> client will look for symbols within the application instead.
> *For example:*
> Using this region definition:
> {code:xml}
> <region name="region_part_a">
> <region-attributes refid="CACHING_PROXY"
> pool-name="partitioned-pool">
> <partition-resolver library-function-name="createPartitionResolver"/>
> </region-attributes>
> </region>
> {code}
> And within the application defining this function:
> {code:cpp}
> APPLICATION_EXPORT PartitionResolver* createPartitionResolver()
> {
> return new StringPrefixPartitionResolver{};
> }
> {code}
> You could declaratively create a region which uses the
> StringPrefixPartitionResolver.
> *IMPORTANT.* Take into account that documentation should be updated in order
> to indicate that library-name will become an optional field and what it means
> whenever it's not present.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
